Closed
Bug 1496741
Opened 6 years ago
Closed 6 years ago
[remote-dbg-next] Cleanup shared adb-addon helper
Categories
(DevTools :: about:debugging, enhancement, P1)
DevTools
about:debugging
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
Follow up to Bug 1488506 with more refactor and cleanup of our adb addon wrapper.
Assignee | ||
Comment 1•6 years ago
|
||
This introduces constants for the addon states and migrates ADBAddon to a class
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7b218b6df420 Cleanup adb-addon.js module;r=ladybenko
Comment 3•6 years ago
|
||
Backed out changeset 7b218b6df420 (Bug 1496741) for mochitest-chrome failures on devtools/client/webide/test/test_addons.html. Backout: https://hg.mozilla.org/integration/autoland/rev/74dab269778e16c2e62aa8f4039d8542933970f9 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending,running,success,testfailed,busted,exception&revision=7b218b6df4207d8b4338ab682bc2c09f3d8eaadb&selectedJob=204244475 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=204244475&repo=autoland&lineNumber=4051
Flags: needinfo?(jdescottes)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(jdescottes)
Assignee | ||
Comment 4•6 years ago
|
||
Wrong constant value for the "installing" status ... Sorry about that, will reland on inbound.
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a7a2ce19cf57 Cleanup adb-addon.js module;r=ladybenko
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a7a2ce19cf57
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•