Closed Bug 1496746 Opened 3 years ago Closed 2 years ago
We got rid of the per-directory manual VPATH definitions in bug 875013, but we still generate a VPATH entry for the srcdir in the Makefiles created in the objdir. Since issues with VPATH can be tricky (eg: https://bugzilla.mozilla.org/show_bug.cgi?id=1461714#c55), we should consider removing this. We have enough information in moz.build to point directly to source files, and the fact that we can build the tree in an alternate build system without VPATH should be confirmation of this.
Is referring to source files via full paths going to do weird things with debug info/crash-stats links/etc.?
(In reply to Nathan Froyd [:froydnj] from comment #1) > Is referring to source files via full paths going to do weird things with > debug info/crash-stats links/etc.? I don't think so, but we could presumably diff the list of source files in the generated .sym files before and after if someone writes the patch. The code in dump_syms already builds full paths using the compile dir + the source filename.
With :kmoir's consent, I'm reviewing the backlog for bugs in FFx Build System to see if we can do some things to clean up the backlog. This bug appears to be an enhancement or feature request. If so, please set the bug's severity to `enhancement` and/or add the `feature` keyword depending on if this is an improvement to an existing thing, or a new feature/tool/system.
Severity: normal → enhancement
Attachment #9087218 - Attachment description: Bug 1496746 - Remove VPATH; r?#firefox-build-system-reviewers → Bug 1496746 - Remove VPATH; r?glandium
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/b2e49b3d407e Remove VPATH; r=glandium
You need to log in before you can comment on or make changes to this bug.