1496752 - Allow extraDragSpace in title bar

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Andy]

Attachment: Thunderbird-tabs.png

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0

Steps to reproduce:

Update to Thunderbird 60


Actual results:

drawInTitlebar became available – awesome!

But it doesn't leave much space to drag the window any more.


Expected results:

Just like Firefox an horizontal offset for the first tab and the option tabs.extraDragSpace would help.

Comment 1

[Andy]

Attachment: Tabs in Firefox leave space to drag the window

Comment 2

[Andy]

Firefox removes the offset and the dragSpace when you maximize the window.

Comment 4

[Richard Marti (:Paenglab)]

Isn't on the right of the tabs enough drag space? In TB there are normally not so much tabs open which completely fills the tabbar. Also when this would be the case there is still free space provided on the right.

Comment 5

[Wayne Mery (:wsmwk)]

Note - dragging to the left of the leftmost tab would break the historical standard behavior that the first/leftmost tab is fixed/not movable. bug 485268

Actually, I am running 63.0b1 and drag to left of first tab works. But it has a nasty result, a new 3-pane window is opened with two tabs - the leftmost tab and the dragged tab

Comment 6

[Jorg K (CEST = GMT+2)]

(In reply to Richard Marti (:Paenglab) from comment #4)
> Isn't on the right of the tabs enough drag space? In TB there are normally
> not so much tabs open which completely fills the tabbar.
> My tabbar is 100% full: Mail, Activity Manager, Add-ons, Chat, Calendar, Options.

> Also when this would be the case there is still free space provided on the right.
I don't understand. On the right I have the two Calendar icons. Without titlebar I couldn't move the window at all.

Comment 7

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+2) from comment #6)
> I don't understand. On the right I have the two Calendar icons. Without
> titlebar I couldn't move the window at all.

On the right of the tabs is on the left of the Calendar icons: the drag space is between the tabs and the Calendar icons. And this works here. Also on the right of the Calendar icons is a small space where you can drag.

Comment 8

[Andy]

> a small space where you can drag.
well that's exactly the issue here: a SMALL space.

The small space makes it hard for mouse users, and almost impossible for touch screen users, to grab the window to drag it.

This bug is a usability and accessibility improvement (if solved).

In Firefox an elegant solution was found for that issue, the reasoning behind it is probably documented.

Comment 9

[Richard Marti (:Paenglab)]

Between the tabs and the Calendar button is a dragspace of minimal 40px.

Andy, can you attach a screenshot of your TB window? The top part with titlebar and toolbar is enough.

Comment 10

[Andy]

Attachment: Thunderbird tabs with no space left to drag at all

Comment 11

[Andy]

Richard, I added that screenshot, there is no space left at all.

Still, 40px is not very much, and a "grab handle" between tabs and icons doesn't provide much of an affordance.

Comment 12

[Richard Marti (:Paenglab)]

Okay, I forgot to add this 40px on Linux because this feature came so late on Linux. :-(
40px is also what FX has.

Comment 13

[Richard Marti (:Paenglab)]

Attachment: 1496752-dragspace.patch

This adds the dragspace when drawInTitlebar is enabled and the menubar is hidden.

Comment 14

[Richard Marti (:Paenglab)]

I've set leave-open because I'm planning to port bug 1349552.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/641adfb29437
Add minimal dragspace on tabbar when drawInTitlebar=true on Linux. r=darktrojan

Comment 16

[Richard Marti (:Paenglab)]

Comment on attachment 9015581 [details] [diff] [review]
1496752-dragspace.patch

Beta and ESR are also affected.

Comment 17

[Richard Marti (:Paenglab)]

Attachment: Part 1: 1496752-dragspace.patch

This adds the extra drag space of 8px like FX does. The space is only added when drawInTitlebar is enabled.

The JS code in msgMail3PaneWindow.js is a copy of https://searchfox.org/comm-central/rev/1a3cdb886d501ac08fe3405e70a6b85f51905603/mozilla/browser/base/content/browser-tabsintitlebar.js#315-345

To enable it chsnge mail.tabs.extraDragSpace to true. With part 2 it can be changed in customize window.

I separated customize patch to not need to remove it because of the string changes, when we want to uplift to beta or maybe ESR (I have patches when needed).

Comment 18

[Richard Marti (:Paenglab)]

Attachment: Part 2: 1496752-addDragSpaceConfig.patch

Added the possibility to enable the drag space in customize window. I stacked both settings for the titlebar to make the dialog too wide.

Comment 19

[Jorg K (CEST = GMT+2)]

Comment on attachment 9016381 [details] [diff] [review]
Part 1: 1496752-dragspace.patch

Review of attachment 9016381 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK, but one obvious copy/paste error present.

::: mail/app/profile/all-thunderbird.js
@@ +476,5 @@
>  #endif
>  
> +// Offer additional drag space to the user. The drag space
> +// will only be shown if browser.tabs.drawInTitlebar is true.
> +pref("mail.tabs.extraDragSpace", false);

How will users discover that?

::: mail/base/content/msgMail3PaneWindow.js
@@ +1995,5 @@
> +  if (window.windowState == window.STATE_MAXIMIZED)
> +    window.restore();
> +  else
> +    window.maximize();
> +}

Oops, look 10 lines above, we have that function already.

Comment 20

[Jorg K (CEST = GMT+2)]

(In reply to Jorg K (GMT+2) from comment #19)
> How will users discover that?
OK, via part 2.

Comment 21

[Richard Marti (:Paenglab)]

Attachment: Part 1: 1496752-dragspace.patch v2

(In reply to Jorg K (GMT+2) from comment #19)
> Comment on attachment 9016381 [details] [diff] [review]
> Part 1: 1496752-dragspace.patch
> 
> Review of attachment 9016381 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks OK, but one obvious copy/paste error present.
> 
> ::: mail/app/profile/all-thunderbird.js
> @@ +476,5 @@
> >  #endif
> >  
> > +// Offer additional drag space to the user. The drag space
> > +// will only be shown if browser.tabs.drawInTitlebar is true.
> > +pref("mail.tabs.extraDragSpace", false);
> 
> How will users discover that?
> 
> ::: mail/base/content/msgMail3PaneWindow.js
> @@ +1995,5 @@
> > +  if (window.windowState == window.STATE_MAXIMIZED)
> > +    window.restore();
> > +  else
> > +    window.maximize();
> > +}
> 
> Oops, look 10 lines above, we have that function already.

Nothing found there but 7 lines above. ;-) Was a copy paste error.

Comment 22

[Jorg K (CEST = GMT+2)]

applying 1496752-dragspace.patch
patching file mail/themes/osx/mail/tabmail.css
Hunk #2 FAILED at 69
1 out of 2 hunks FAILED -- saving rejects to file mail/themes/osx/mail/tabmail.css.rej

:-(

Comment 23

[Richard Marti (:Paenglab)]

Sorry, forgot to write you need bug 1492962 applied first. I hope it will get review soon.

Comment 24

[Jorg K (CEST = GMT+2)]

Comment on attachment 9016383 [details] [diff] [review]
Part 2: 1496752-addDragSpaceConfig.patch

Sorry, I don't want these in the queue if I cannot review them.

Comment 25

[Richard Marti (:Paenglab)]

Comment on attachment 9016383 [details] [diff] [review]
Part 2: 1496752-addDragSpaceConfig.patch

So, bug 1492962 landed now.

Comment 26

[Jorg K (CEST = GMT+2)]

This went thoroughly wrong :-( - With no Target Milestone the uplifts were never seen. The first patch landed on TB 64 in comment #15, so that is already in TB 64 beta.

Comment 27

[Jorg K (CEST = GMT+2)]

Comment on attachment 9015581 [details] [diff] [review]
1496752-dragspace.patch

Too late for TB 63 beta, I'll take it to the ESR.

Comment 28

[Jorg K (CEST = GMT+2)]

Comment on attachment 9016383 [details] [diff] [review]
Part 2: 1496752-addDragSpaceConfig.patch

Looks good.

Comment 29

[Jorg K (CEST = GMT+2)]

Comment on attachment 9016440 [details] [diff] [review]
Part 1: 1496752-dragspace.patch v2

Mostly ported from FF code, thanks.

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/50a2faafdfbf
Part 1: Add optional drag space on top of the tabstrip. r=jorgk
https://hg.mozilla.org/comm-central/rev/c19d24ccbc89
Part 2: Make it possible to enable the extra drag space in customize window. r=jorgk

Comment 31

[Jorg K (CEST = GMT+2)]

Last two parts landed on TB 65.

Comment 32

[Jorg K (CEST = GMT+2)]

TB 60.3:
https://hg.mozilla.org/releases/comm-esr60/rev/2de77be99801019ffe9dadbb05819c811272f26a
Simple fix from comment #15.