Closed Bug 1496764 Opened Last year Closed 11 months ago

browser_UsageTelemetry_searchbar.js,browser_UsageTelemetry_urlbar.js are going to permafail when the Gecko version number is bumped to 65 on 2018-10-22

Categories

(Firefox :: Search, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
geckoview62 --- unaffected
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 --- unaffected
firefox64 + unaffected
firefox65 --- fixed

People

(Reporter: CosminS, Assigned: mikedeboer)

References

Details

Attachments

(2 files)

Version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=65f11d59516f23b3edd12b8b5e993624bc149918&searchStr=browser,chrome&selectedJob=203647020

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=203645501&repo=try&lineNumber=4220

This got introduced by this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1492233

[task 2018-10-05T13:51:11.464Z] 13:51:11     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_searchbar.js | The key other-MozSearch.searchbar must contain 1. - 1 == 1 - 
[task 2018-10-05T13:51:11.466Z] 13:51:11     INFO - Buffered messages finished
[task 2018-10-05T13:51:11.469Z] 13:51:11     INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_searchbar.js | Should have matching amount of events. - 0 == 1 - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser/head.js :: checkEvents :: line 150
[task 2018-10-05T13:51:11.471Z] 13:51:11     INFO - Stack trace:
[task 2018-10-05T13:51:11.472Z] 13:51:11     INFO - chrome://mochitests/content/browser/browser/modules/test/browser/head.js:checkEvents:150
[task 2018-10-05T13:51:11.472Z] 13:51:11     INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_UsageTelemetry_searchbar.js:test_plainQuery:123
[task 2018-10-05T13:51:11.473Z] 13:51:11     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
[task 2018-10-05T13:51:11.473Z] 13:51:11     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
[task 2018-10-05T13:51:11.475Z] 13:51:11     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:986
[task 2018-10-05T13:51:11.476Z] 13:51:11     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
Flags: needinfo?(mozilla)
Actually, this is all of our search telemetry (it wasn't just introduced by that bug). It was introduced by bug 1316281
Flags: needinfo?(mozilla)
Panos, Dave, you're listed as contacts for this telemetry event; does it need to be extended or the test updated?
Flags: needinfo?(past)
Flags: needinfo?(dzeber)
I don't know, but I'm sure Mike does!
Flags: needinfo?(past) → needinfo?(mdeboer)
Priority: -- → P1
Flags: needinfo?(dzeber)
Reminder: Version increase is next Monday, 2018-10-22. This needs to be fixed before that.
This
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Flags: needinfo?(mdeboer)
Attachment #9018559 - Flags: review?(francois)
Comment on attachment 9018559 [details]
Bug 1496764 - extend search event telemetry to never expire and change the probe owners. r?chutten!,Standard8!

Please flag me again on Phabricator once you've found the original data review request or filled out a new one.
Attachment #9018559 - Flags: review?(francois)
François, the original data review(s) for these probes can be found here:
* https://bugzilla.mozilla.org/show_bug.cgi?id=1316281#c22
* https://bugzilla.mozilla.org/show_bug.cgi?id=1368937#c4

I'll re-flag you in Phabricator, if you don't mind :) Thanks!
Seems like once you resign yourself from a revision, I'm not the one who can re-request review. Doing it the old-fashioned way, instead!
Attachment #9018559 - Flags: review?(francois)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/c44fbdd51735
Disable browser_UsageTelemetry_searchbar.js until telemetry probe has been extended to fix permafail on version increase. a=version-increase-fix
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/201d73cddf06
Disable browser_UsageTelemetry_urlbar.js until telemetry probe has been extended to fix permafail on version increase. a=version-increase-fix
Summary: browser_UsageTelemetry_searchbar.js is going to permafail when the Gecko version number is bumped to 65 on 2018-10-22 → browser_UsageTelemetry_searchbar.js,browser_UsageTelemetry_urlbar.js are going to permafail when the Gecko version number is bumped to 65 on 2018-10-22
Attachment #9018559 - Flags: review?(francois)
Attachment #9027862 - Flags: review?(chutten)
Attachment #9018559 - Attachment description: Bug 1496764 - extend search event telemetry to expire in Fx 70 and change one of the probe owners. r?francois! → Bug 1496764 - extend search event telemetry to never expire and change the probe owners. r?chutten!,Standard8!
Comment on attachment 9027862 [details]
EventsTelemetryCollectionRequest.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? 

Yes. This collection is Telemetry which is documented in the definitions file (Scalars.yaml), the Probe Dictionary, and on telemetry.mozilla.org's Measurement dashboard.

    Is there a control mechanism that allows the user to turn the data collection on and off? 

Yes. This collection is Telemetry which can be disabled in Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes. Ryan Harter and Mike de Boer.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on, all channels.

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

Nothing new. It continues the collection of search engine ids which are of a known range.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. The collection is permanent.

---
Result: datareview+
Attachment #9027862 - Flags: review?(chutten) → review+
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82bdbaebd7fe
extend search event telemetry to never expire and change the probe owners. r=chutten,Standard8
Looks like the leave-open was a leftover from Aryx's previous band-aid.
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.