1496793 - Event telemetry should trim values if length > 80 chars

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

In some scenarios, it seems we are nearing the length limit for some telemetry APIs.

STRs:
- open about:debugging#addons
- load a temporary web extension that has a devtools panel (I used a local build of https://github.com/captainbrosset/devtools-highlighter)
- open devtools
- select the panel coming from the extension

In the logs I had 

JavaScript error: resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/telemetry.js, line 554: Error: The property "first_panel" was added to a telemetry event with the signature open,tools,null but it's value "webext-devtools-panel-dd850311925d52323a7ff2cf42edb9e13a4e5662_temporary-addon-18-0" is longer than the maximum allowed length of 80 characters

This error is generated from our telemtry wrapper. In that case, the tool name was made longer by the fact that it was loaded as a temporary addon, and reached 83 chars.

webext-devtools-panel-dd850311925d52323a7ff2cf42edb9e13a4e5662_temporary-addon-18-0

Maybe instead of throwing (and not sending the event) we should trim and log an error/warning?

Comment 1

[Julian Descottes [:jdescottes]]

Mike, as discussed here is the bug for modifying our logic around the 80characters limit in event telemetry.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We should trim all event property values.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1496793 - Event telemetry should trim values if length > 80 chars

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55515c0020e1
Event telemetry should trim values if length > 80 chars r=jdescottes

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/55515c0020e1