Bug 1496815 - Suggest search engine aliases in the address bar when '@' is typed as the first character
46 bytes, text/x-phabricator-request
|Details | Review|
For a visual explanation, please see Verdi's second bulleted mockup over at https://mozilla.invisionapp.com/share/4POCDI07U9A#/screens/322966230_Seach_Bar_Changes_For_63 If possible, we'd try and make sure that whenever an ampersand '@' is entered in the address bar, we show a list of aliases to autofill to a complete search engine alias.
Priority: -- → P2
Summary: Show only autosuggest results when search only engine alias is typed in the address bar → Suggest and autofill search engine aliases in the address bar when '@' is typed as the first character
[Tracking Requested - why for this release]: Moving the tracking? flag from bug 1496772 to this bug, per bug 1496772 comment 5: (In reply to Mike de Boer [:mikedeboer] from bug 1496772 comment #0) > [Tracking Requested - why for this release]: > > There are a number of - should be - low effort changes to improve the search > tiles/ keywords user interaction. > We believe this will greatly impact the general usefulness, usability and > users' perception of the feature when it launches in Firefox 63.
I split out the autofill part of this bug into bug 1499581. The implementations of the popup/suggest part and the autofill part of Verdi's mockup are different and separable enough that each part deserves its own bug and patch I think.
Summary: Suggest and autofill search engine aliases in the address bar when '@' is typed as the first character → Suggest search engine aliases in the address bar when '@' is typed as the first character
This bug touches just about every part of the urlbar: UnifiedComplete, the autocomplete binding, the formatter, CSS. This builds on the patches in bug 1496814 and bug 1496811.
I think we should file a bug to change the restrict url char, because "@" conflicts with it and it wasn't a very good choice. At this point the thing has shipped and we should change the old restriction char. we could probably change it to ~ if we remove the typed restriction char, freeing it up. I'll file it.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/eab3a0cf6429 Suggest search engine aliases in the address bar when '@' is typed as the first character r=mak
This bug was covered by the over all testing efforts invested in the Search shortcuts in the awesomebar feature. Marking this as verified fixed using Firefox 64.0b7 on the following OSes: Windows 7x86, Windows 10x64, Ubuntu 18.04 x64 and macOS 10.14.
6 months ago
You need to log in before you can comment on or make changes to this bug.