1496834 - Windows 10 ToastNotifications do not focus Firefox when clicked

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P1)

Description

[Robin Steuber (they/them) [:bytesized]]

Steps to reproduce:
1) Open IRCCloud in Firefox Nightly on Windows 10
2) Switch to another tab
3) Wait to receive a ToastNotification from IRCCloud (when a user messages you, or when a channel you get notifications on gets a message)
4) Click the notification
5) Firefox switches to the IRCCloud tab
6) Start typing a reply

Expected result:
Typed reply text will display in the "send message" input box

Actual result:
Nothing displays in the "send message" input box because the Firefox window does not have focus.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

[Tracking Requested - why for this release]: regression in usability of desktop notifications.

This functionality was added in bug 853972 (Firefox 29) but was now regressed by bug 1155505. Please make sure to update the test at https://searchfox.org/mozilla-central/source/browser/base/content/test/alerts/browser_notification_tab_switching.js to cover the native notifications.

Comment 2

[Makoto Kato [:m_kato]]

Toast Notification isn't turn on 64 release, so this isn't blocker for 64.

And our unit test cannot use OS's toast because native toast requires AppId in shortcut file (it requires installer build that is *.exe)

Comment 3

[Makoto Kato [:m_kato]]

I guess that clicking notification causes that application focus is switched.  So we need set focus to Firefox again for windows.  bug 853972's fix uses fm.setActiveWindow, but the latest code doesn't use it.  So firefox cannot take window focus...

Comment 4

[Makoto Kato [:m_kato]]

That change was bug 960997

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking this to make sure and follow up for 66 and possibly for 65.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This feature is Nightly-only, so no need to track for 65.

Comment 7

[Revertron]

This bug is relevant to Slack to (in 67 nightly).

Comment 8

[Revertron]

Any news here?

Comment 9

[Revertron]

Is it so difficult to add some focus request?

Comment 10

[Makoto Kato [:m_kato]]

Attachment: Bug 1496834 - Set focus on Firefox since focus is moved to another process.

When clicking native toast on Windows 10, focus moves to another process,
So we have to set focus on Firefox process.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b296f51555f8
Set focus on Firefox since focus is moved to another process. r=aklotz

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b296f51555f8

Comment 13

[Daniel Bodea [:danibodea]]

I have reproduced this issue in Nightly v71.0a1 from 2019-10-01 and verified it in Nightly v71.0a1 from 2019-10-08 in Windows 10.