Make it easier to deal with <xul:browser>'s flipping between different content processes

RESOLVED FIXED in Firefox 64

Status

()

enhancement
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(3 attachments)

In bug 1472212, a pref is being added that will allow us to use a separate content process for Activity Stream.

There are a few places in our testing code that expects to be able to attach web progress listeners to a tab hosting Activity Stream, and for those listeners to work properly as Activity Stream is navigated away from.

With the new Activity Stream content process, this breaks down, since the process flip causes the original message manager to be invalidated by a new one associated with the new process.

My first patch makes it so that nsIWebProgressListener's associated with a remote <xul:browser> will persist between remote-to-remote process flips (but _not_ from remote to non-remote process flips).

The second patch fixes up one of our Activity Stream content search tests so that instead of attempting to abort a test search from Activity Stream (presumably to save time), it allows the search to go through, and works properly with or without process flipping.
Assignee

Updated

9 months ago
Assignee: nobody → mconley
Assignee

Comment 2

9 months ago
For simplicity, we do not support remote-to-non-remote or non-remote-to-remote
nsIWebProgressListener persistence.
Assignee

Comment 3

9 months ago
This is to simplify a later patch that makes it easier to deal with process
flipping.

Depends on D7936

Comment 5

9 months ago
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c5bbbe511ec5
Make RemoteWebProgressManager survive remote-to-remote process flips. r=Felipe
https://hg.mozilla.org/integration/autoland/rev/2c3fc67d57b9
Get rid of message manager global from browser_ContentSearch.js. r=adw
https://hg.mozilla.org/integration/autoland/rev/9f11d400d1cc
Make browser_ContentSearch.js work with process flips. r=adw

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c5bbbe511ec5
https://hg.mozilla.org/mozilla-central/rev/2c3fc67d57b9
https://hg.mozilla.org/mozilla-central/rev/9f11d400d1cc
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.