1496880 - Add helpful text about multiple LDAP accounts and link to FAQ to permissions error message

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement)

Description

[Mark Côté [:mcote]]

It's not uncommon for employees who used to be volunteers to have two LDAP accounts, using their volunteer account for landing code, and their employee account for everything else, in particular Auth0 logins.  Hence when they log into Lando, they are surprised when it tells them that they don't have L3 access.

We have FAQ entries for this (https://wiki.mozilla.org/Phabricator/FAQ#Lando_says_.22You_have_insufficient_permissions_to_land._Level_3_Commit_Access_is_required..22_What_do_I_do.3F and https://wiki.mozilla.org/Phabricator/FAQ#My_SCM_level_is_bound_to_a_different_LDAP_account_from_my_Mozilla_one._How_do_I_log_into_Lando_to_land_changes.3F, with the latter being more pertinent for this specific situation).  It will avoid a lot of confusion if we provide some brief text and link to those entries from the insufficient-permissions error page.

Comment 1

[Israel Madueme [:imadueme]]

So we need a link in the blockers message. Also the blocker message isn't always specific to the case where the user has 2 LDAP accounts (it is impossible for lando-api to know that a user has another LDAP account with the correct permissions).

If we want to get this done quickly, we can add a catchall 'If you have 2 LDAP accounts see the FAQ' to the error message in the api and have Lando UI autolink that specific phrase.

If we want to start linking based on warning/blocker ids, that would be a different route.

Planning on doing the former.

Comment 2

[Israel Madueme [:imadueme]]

We could also just autolink 'FAQ' and then be able to use that creatively in any blocker/warning message.

Comment 3

[Israel Madueme [:imadueme]]

Attachment: landings: improve insufficent permissions error message (Bug 1496880)

We add a "See the FAQ for help" to the end of these messages. Our UI
will then link out to the FAQ in that location so that users can learn
how to resolve the problem.

Comment 4

[Israel Madueme [:imadueme]]

Attachment: template_helpers: linkify the FAQ keyword (Bug 1496880)

Some warnings and blocker message from the api have the FAQ keyword
in them. It would be good to turn that into a link the user can easily
click on, which we do in this commit.