1497009 - Mail context menu starts with separator in "normal" folders, not Drafts and Templates

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Jorg K (CEST = GMT+2)]

Looks like there is a mechanism to hide "Edit Draft Message" and "New Message from Template" / "Edit Template", but it forgot to hide the following separator.

Looks slightly odd in TB 60 and I'm surprised no one has complained yet.

Richard, could you please take a look.

Comment 1

[Jorg K (CEST = GMT+2)]

This thing, right?
https://searchfox.org/comm-central/rev/42bb5729167259ec2cdcabdb4bb816ae91b4156f/mail/base/content/mainNavigationToolbox.inc#653

Comment 2

[Richard Marti (:Paenglab)]

No, your separator is in the Go menu. It's more this one.
https://searchfox.org/comm-central/rev/42bb5729167259ec2cdcabdb4bb816ae91b4156f/mail/base/content/mainPopupSet.inc#1300

Comment 3

[Jorg K (CEST = GMT+2)]

Right, and the context menu seems to be done in code:
https://searchfox.org/comm-central/source/mail/base/content/mailContextMenus.js

And there they are busily hiding the draft and edit commands but not the separator :-(

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1497009-hideSeparator.patch

This should do it.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9015084 [details] [diff] [review]
1497009-hideSeparator.patch

Works great. Thanks. Finally I'll get rid of the ugly separator. Obviously not many people know this trick.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bf1c31c2f2b2
Add the mailContext-sep-editTemplate separator to the hideIfAppropriate group. r=jorgk

Comment 7

[Jorg K (CEST = GMT+2)]

TB 60.3:
https://hg.mozilla.org/releases/comm-esr60/rev/577477b791f0bd47d9769aa3d043a72d2bdcc7f5

Comment 8

[Jorg K (CEST = GMT+2)]

Confirmed working in ESR build.

Comment 9

[Jorg K (CEST = GMT+2)]

TB 63.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/a63ea27d4417