149702 - [PATCH] Pre-Size nsXMLMIMEDataSource::mInfoArray before appending elements to it

Status: VERIFIED INVALID

(SeaMonkey :: General, defect)

Description

[ArronM (:paper)]

mInfoArray currently contains 24 elements (23 ifndef MOZ_SVG).  This list is
static, so why not init the array to 24 before appending.  nsSupportsArray grows
its array size by increments of 8.  This'll save 2 grow calls.

I really don't know what impact removing 2 grow calls have, but it's a
optimization, nonetheless!

Comment 1

[ArronM (:paper)]

Attachment: a simple patch

Comment 2

[Keyser Sose]

Thanks for the patch...Marking NEW for patch review and goodness.

Comment 3

[benc]

Not familiar with this, can someone explain how this is Networking?

Comment 4

[ArronM (:paper)]

Benjamin, I put it in Networking only because nsXMLMIMEDataSource is in 
the /mozilla/netwerk/ directory.  If you have a better component for it, don't 
hesitate to move it! :)  

Comment 5

[benc]

-> browser-general, b/c matti knows all.

Comment 6

[ArronM (:paper)]

Attachment: Set Initial Size of mInfoObjects and mInfoArray to size of static list

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 87268 [details] [diff] [review]
Set Initial Size of mInfoObjects and mInfoArray to size of static list

r=biesi

I trust that you your count is correct

Comment 8

[Matthias Versen [:Matti]]

-> [e-mail]

Comment 9

[Darin Fisher]

Comment on attachment 87268 [details] [diff] [review]
Set Initial Size of mInfoObjects and mInfoArray to size of static list

patch seems fine, but is this code actually run? 
uriloader/exthandler/nsExternalHelperAppService overrides necko's impl of
nsIMIMEService, which is the only code that uses nsXMLMIMEDataSource (or so i
thought).

sr=darin if you verify that this code is actually used by mozilla.

Comment 10

[ArronM (:paper)]

Darin, I asked that same question a day after I created the patch.  I haven't 
had time yet to look into it, but it's on my list of todos.  I always assumed 
it ran, but haven't seen any obvious way it is.  If it isn't run, the static 
list is just silly and causes one more step in adding a mimetype (a image 
decoder, for example)

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

per bug 172963 sounds like this file is indeed unused. could be WONTFIX or
INVALID, going for the second.

Comment 12

[ArronM (:paper)]

nsXMLMIMEDataSource.cpp is now been cvs removed.. verifying invalid :)