Closed Bug 1497033 Opened 6 years ago Closed 6 years ago

menulists not aligned in fonts dialog

Categories

(Thunderbird :: Preferences, defect)

Product:
Thunderbird
Component:
Preferences
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr6063+ fixed, thunderbird63 wontfix, thunderbird64 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 64.0
Tracking Flags:
Tracking Status
thunderbird_esr60 63+ fixed
thunderbird63 --- wontfix
thunderbird64 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(4 files)

fonts-menulist-align.png
1.46 KB, image/png
Details
1497033-small-margin.patch
2.97 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
1497033-small-margin-ESR.patch
2.98 KB, patch
jorgk-bmo
: approval-comm-esr60+
Details | Diff | Splinter Review
1497033-small-margin-beta.patch
3.05 KB, patch
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review 
In prefs the menulists aren't right aligned in fonts dialog.
Removing the small-margin class fixes the issue. In newTagDialog.xul the class doesn't apply because the input is now in HTML namespace, removing the class too.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9015107 - Flags: review?(jorgk)
Comment on attachment 9015107 [details] [diff] [review]
1497033-small-margin.patch

Thanks, works for me. It's misaligned in the ESR, too. So uplift?
Attachment #9015107 - Flags: review?(jorgk) → review+
Comment on attachment 9015107 [details] [diff] [review]
1497033-small-margin.patch

I haven't checked it in ESR because I thought it will be correctly aligned in the non-in-content dialogs. But it is also mis-aligned. Removing the class from newTagDialog.xul too makes the button a bit bigger but it still looks good.
Attachment #9015107 - Flags: approval-comm-esr60?
Attachment #9015107 - Flags: approval-comm-beta?
Keywords: checkin-needed
Comment on attachment 9015107 [details] [diff] [review]
1497033-small-margin.patch

Thanks.
Attachment #9015107 - Flags: approval-comm-esr60?
Attachment #9015107 - Flags: approval-comm-esr60+
Attachment #9015107 - Flags: approval-comm-beta?
Attachment #9015107 - Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b483bf18ee58
Fix alignment issues by removing the small-margin class in prefs/fonts- and tags dialog. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
Comment on attachment 9015107 [details] [diff] [review]
1497033-small-margin.patch

The patch doesn't apply due to the colorpicker change, at least in the tags file. Since beta/esr still have colorpicker, so no HTML namespace, maybe the removal should be done there. So I'll leave the rebasing to you to avoid mistakes.
Flags: needinfo?(richard.marti)
Attachment #9015107 - Flags: approval-comm-esr60+
Attachment #9015107 - Flags: approval-comm-beta+
Patch for ESR.
Flags: needinfo?(richard.marti)
Attachment #9015119 - Flags: approval-comm-esr60?
Patch for beta.
Attachment #9015120 - Flags: approval-comm-beta?
Attachment #9015119 - Flags: approval-comm-esr60? → approval-comm-esr60+
Attachment #9015120 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: