Show the star icon if an autofill entry is bookmarked

NEW
Unassigned

Status

()

defect
P5
normal
7 months ago
6 months ago

People

(Reporter: wip.the.gruik, Unassigned)

Tracking

64 Branch
Points:
---

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox62 wontfix, firefox63 affected, firefox64 affected)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 months ago
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
Build ID: 20181007100131

Steps to reproduce:
  - disable search suggestions (not mandatory but easier to see results)
  - in about:config ensure that browser.urlbar.autoFill=true
  - visit https://badssl.com/
  - bookmark the page
  - open a new tab and close the one displaying badssl.com
  - clear all histories
  - focus the address bar (Ctrl-L) and type "badssl"

Actual results:
  The text in the address bar is auto-filled to "badssl.com/".
  Only one item is proposed in the dropdown "https://badssl.com — Visit".
  The item is displayed as if it is an history entry and not a bookmark.

Expected results:
  The proposed item should have been displayed as a bookmark, that's to say
  prefixed with the bookmark star icon and the matching bookmark's name.

Note: typing "adssl", without the beginning "b", does not trigger the auto-fill
and then the bookmark entry is correctly displayed.

Comment 1

7 months ago
No star mark display in dropdown.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=07ce49ea766251752bd28fb0eda76ec20c2046ce&tochange=f4f0af49af15aea7484896dd856b2bceefb080c0

Regressed by: f4f0af49af15	Drew Willcoxon — Bug 1488879 - Autofill non-hidden origins and URLs with frecencies <= 0. r=mak
Blocks: 1488879
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
This is not a regression as far as I can tell, certainly at least not a recent one...  You can reproduce the STR in comment 0 with Firefox 62, for example.

If this is at all a regression, it's due to UnifiedComplete, which has been in Firefox for a long time now.  We don't include a bookmark-styled result in this case because the heuristic autofill result already matches the bookmark (badssl.com in this case), and autofill results are styled as visit results, not bookmark results.  The obvious alternative here is to style the autofill result as a bookmark result, and maybe that's something we should consider doing.  (Another (worse) alternative would be to add a second, bookmark-styled result.)

As for bug 1488879, the only difference before and after that bug is that now bookmarks will be autofilled immediately.  Before, you could still reproduce this behavior, but you might need to visit (or type) badssl.com one or more times before it would start autofilling.
No longer blocks: 1488879
Keywords: regression
Priority: -- → P5
Although now that I read what I wrote, it's fair to say that you'll probably see this behavior more often now than you did before, due to bug 1488879.  It depends on whether what you type is the domain of your bookmark, and whether your bookmark was autofilling before bug 1488879.

I'll mark bug 1488879 as a see-also instead of a depends-on because I still don't think it's fair to simply say bug 1488879 caused this.
See Also: → 1488879

Comment 4

7 months ago
But, after landing of Bug 1488879, with str comment#0, star icon with url would not display in the suggested dropdown list.
So this is definitely regression(or bad sideeffect) caused by the that Bug 1488879.
(Reporter)

Comment 5

7 months ago
Just a little explanation of how I use Firefox for everybody to understand why I filled this bug.

First, I set Firefox to clean all browsing history on exit.
Once the browser is closed, I no longer care about what sites I had visited (otherwise they were bookmarked).
I personally consider that previous session history clutter up the awesomebar results.
That said, I do use the browsing history during a single session quite often... through the awesomebar.

Second, I find the awesomebar very convenient to bring up bookmarks to where I want to navigate.
In certain cases, like banking sites, I find reassuring that the awesomebar explicitly confirms that I am opening
one of my own bookmarks and not some fishy site that might linger in my history despite the clean-up (of course
the site certificate and the star icon are better cues, but the more the better).

With this in mind, my usual workflow is the following:
  - To visit a site I know, I start typing its name to bring up the bookmark through the awesomebar.
  - In the same browsing session, if I want to go back to a site I closed the tab, I type its name
    for the awesomebar to offer me the matching history.

With Firefox 62, since I always start with no history at all, when I type a site name I am systematically
proposed either to search for what I just typed or open the matching bookmark. I now realize that I never
see what I type being auto-filled... so much I thought this was a new feature for Firefox 64.

However, with Nightly 64, auto-fill kicks in immediately even with a completely empty/clean history.
From this point of view, not having my bookmarks in the awesomebar results is a kind of behavioral regression.

I don't think a specific bug 'regressed' what I describe, it's just the global logic changes in Nightly that
break my habits... and I may not represent that much users.

---

About the STR, I may not have been precise enough with the "clear all histories" step.
By that I meant: Hamburger menu -> Library -> History -> Clear recent history -> Time Range: Everything + Browsing History.
Doing that, Firefox 62 and Nightly 64 do not have the same behavior.
The behavior is what we want at this time. It may be a problem for your specific habit I understand that, unfortunately it's very hard to satisfy every single use case.
For your case, you could find more handy to just disable autoFill, if it interrupts your flow.

The bug I see here is just that we don't show a star for autofilled entries, we could, to better communicate the source of the entry and give the user more "faith" (rather than requiring blind trust), that looks like what you are looking for here.
Summary: [Awesomebar] Wrong display if typed text matches a bookmark and is auto-filled → Show the star icon if an autofill entry is bookmarked
(Reporter)

Comment 7

6 months ago
Marco, I totally agree with your statements.
I just wonder how long disabling autofill will be supported.

Whatever, my problem is indeed not that the entry is wrong but that nothing indicates that it comes from a bookmark.

In addition, I have thought of another use case witch could be a little more widespread for users disabling history suggestions in the settings (about:preferences#privacy -> Address Bar -> [_] Browsing history).
For these users, the autofill entry looking like an history one may be unsettling since they expected a bookmark-looking entry.
(In reply to Franck (Wip) from comment #7)
> Marco, I totally agree with your statements.
> I just wonder how long disabling autofill will be supported.

I can't predict the future, but I don't see a reason why we should not allow to disable it.

> Whatever, my problem is indeed not that the entry is wrong but that nothing
> indicates that it comes from a bookmark.

That's my understanding indeed.

> In addition, I have thought of another use case witch could be a little more
> widespread for users disabling history suggestions in the settings
> (about:preferences#privacy -> Address Bar -> [_] Browsing history).
> For these users, the autofill entry looking like an history one may be
> unsettling since they expected a bookmark-looking entry.

Yes, it's pretty much the same thing, if you don't trust us doing the right thing, then you surely may want to check with your eyes, and the star would be a good way to cover that requirement.
You need to log in before you can comment on or make changes to this bug.