1497087 - Remove eula support from add-ons manager

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P5)

Description

[Collin Wing]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Comment 1

[Collin Wing]

There is a small section in extensions.dtd that are in eula.xul instead of extensions.xul that need to be converted to fluent.

Comment 2

[Collin Wing]

Attachment: Bug 1497087 Remove eula support from addons manager

Comment 3

[Andrew Swan [:aswan]]

Thanks for picking this up.  Sorry for not noticing this earlier but I'm pretty sure eula.xul is now unreachable so this code is all going to be removed sooner or later.  Feel free to just leave the old dtd around for now if that's easier than revising the existing patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d0174d68cec
Remove eula support from addons manager r=Gijs,aswan

Comment 5

[Dorel Luca [:dluca]]

Backed out changeset 2d0174d68cec (bug 1497087) for mochitest failure on caps/tests/mochitest/test_bug292789.html 

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=207035730&repo=autoland&lineNumber=5034

  INFO - TEST-PASS | caps/tests/mochitest/test_bug292789.html | content should not be able to load <script> from chrome://mozapps 
[task 2018-10-22T17:37:34.044Z] 17:37:34     INFO - Buffered messages finished
[task 2018-10-22T17:37:34.044Z] 17:37:34     INFO - TEST-UNEXPECTED-FAIL | caps/tests/mochitest/test_bug292789.html | Test timed out. 
[task 2018-10-22T17:37:34.045Z] 17:37:34     INFO -     reportError@SimpleTest/TestRunner.js:121:7
[task 2018-10-22T17:37:34.045Z] 17:37:34     INFO -     TestRunner._checkForHangs@SimpleTest/TestRunner.js:142:7
[task 2018-10-22T17:37:34.046Z] 17:37:34     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2018-10-22T17:37:34.047Z] 17:37:34     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2018-10-22T17:37:34.047Z] 17:37:34     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2018-10-22T17:37:34.047Z] 17:37:34     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2018-10-22T17:37:34.048Z] 17:37:34     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2018-10-22T17:37:34.049Z] 17:37:34     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2018-10-22T17:37:34.049Z] 17:37:34     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2018-10-22T17:37:34.050Z] 17:37:34     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2018-10-22T17:37:34.050Z] 17:37:34     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2018-10-22T17:37:34.051Z] 17:37:34     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2018-10-22T17:37:34.052Z] 17:37:34     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2018-10-22T17:37:34.053Z] 17:37:34     INFO -     TestRunner.runTests/<@SimpleTest/TestRunner.js:381:9
[task 2018-10-22T17:37:34.053Z] 17:37:34     INFO -     promise callback*TestRunner.runTests@SimpleTest/TestRunner.js:368:50
[task 2018-10-22T17:37:34.054Z] 17:37:34     INFO -     RunSet.runtests@SimpleTest/setup.js:201:3
[task 2018-10-22T17:37:34.055Z] 17:37:34     INFO -     RunSet.runall@SimpleTest/setup.js:180:5
[task 2018-10-22T17:37:34.055Z] 17:37:34     INFO -     hookupTests@SimpleTest/setup.js:273:5
[task 2018-10-22T17:37:34.056Z] 17:37:34     INFO - parseTestManifest@http://mochi.test:8888/manifestLibrary.js:36:5
[task 2018-10-22T17:37:34.057Z] 17:37:34     INFO - getTestManifest/req.onload@http://mochi.test:8888/manifestLibrary.js:49:11
[task 2018-10-22T17:37:34.058Z] 17:37:34     INFO - EventHandlerNonNull*getTestManifest@http://mochi.test:8888/manifestLibrary.js:45:3
[task 2018-10-22T17:37:34.058Z] 17:37:34     INFO -     hookup@SimpleTest/setup.js:253:5
[task 2018-10-22T17:37:34.058Z] 17:37:34     INFO - EventHandlerNonNull*@http://mochi.test:8888/tests?autorun=1&closeWhenDone=1&consoleLevel=INFO&manifestFile=tests.json&dumpOutputDirectory=%2Ftmp&cleanupCrashes=true:11:1
[task 2018-10-22T17:37:34.764Z] 17:37:34     INFO - GECKO(2318) | MEMORY STAT | vsize 616MB | residentFast 258MB | heapAllocated 66MB
[task 2018-10-22T17:37:34.785Z] 17:37:34     INFO - TEST-OK | caps/tests/mochitest/test_bug292789.html | took 328585ms
[task 2018-10-22T17:37:34.822Z] 17:37:34     INFO - GECKO(2318) | ++DOMWINDOW == 27 (0xdf513400) [pid = 2318] [serial = 51] [outer = 0xe34452f0]
[task 2018-10-22T17:37:34.880Z] 17:37:34     INFO - TEST-START | caps/tests/mochitest/test_bug423375.html
[task 2018-10-22T17:37:34.970Z] 17:37:34     INFO - GECKO(2318) | ++DOMWINDOW == 28 (0xddeb6c00) [pid = 2318] [serial = 52] [outer = 0xe34452f0]
[task 2018-10-22T17:37:35.010Z] 17:37:35     INFO - GECKO(2318) | ++DOCSHELL 0xdd908400 == 14 [pid = 2318] [id = {965cb318-f9a6-4f8f-9130-3707d5588287}]
[task 2018-10-22T17:37:35.011Z] 17:37:35     INFO - GECKO(2318) | [2318, Main Thread] WARNING: NS_ENSURE_TRUE(browserChrome) failed: file /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp, line 12726
[task 2018-10-22T17:37:35.013Z] 17:37:35     INFO - GECKO(2318) | [2318, Main Thread] WARNING: NS_ENSURE_TRUE(browserChrome) failed: file /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp, line 12726
[task 2018-10-22T17:37:35.014Z] 17:37:35     INFO - GECKO(2318) | [2318, Main Thread] WARNING: NS_ENSURE_TRUE(browserChrome) failed: file /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp, line 12726
[task 2018-10-22T17:37:35.016Z] 17:37:35     INFO - GECKO(2318) | ++DOMWINDOW == 29 (0xdd9168d0) [pid = 2318] [serial = 53] [outer = (nil)]
[task 2018-10-22T17:37:35.017Z] 17:37:35     INFO - GECKO(2318) | ++DOMWINDOW == 30 (0xdf520400) [pid = 2318] [serial = 54] [outer = 0xdd9168d0]
[task 2018-10-22T17:37:35.034Z] 17:37:35     INFO - GECKO(2318) | [2318, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/base/Location.cpp, line 88
[task 2018-10-22T17:37:35.037Z] 17:37:35     INFO - GECKO(2318) | [2318, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/base/Location.cpp, line 88
[task 2018-10-22T17:37:35.072Z] 17:37:35     INFO - GECKO(2318) | MEMORY STAT | vsize 616MB | residentFast 260MB | heapAllocated 67MB
[task 2018-10-22T17:37:35.089Z] 17:37:35     INFO - TEST-OK | caps/tests/mochitest/test_bug423375.html | took 206ms

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=2d0174d68cec998537cb529f688c96cfa729a892

Backout:
https://hg.mozilla.org/integration/autoland/rev/c141c2c31ca1eaacdb62b0be052f742b084b9e56

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3377d76041ed
Remove eula support from addons manager r=Gijs,aswan

Comment 7

[:Gijs (he/him)]

Ugh. I hate that test. Filed bug 1279236 years ago to fix it, clearly nobody is doing that, and we're getting rid of bootstrapped add-ons (so presumably bootstrapped manifest infra?) so I didn't do it here. Tag, blocklist.js is the new 'it'.

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3377d76041ed