1497126 - Firefox fails to load nested equal iframes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Andrea Marchesini [:baku]]

Firefox blocks the loading of an iframe with the same URL of the current context ignoring the ref parts. This happens because MAX_SAME_URL_CONTENT_FRAMES is set to 1 here:

https://searchfox.org/mozilla-central/rev/5786b9be9f887ed371c804e786081b476a403104/dom/base/nsFrameLoader.cpp#133

and it's used here:

https://searchfox.org/mozilla-central/rev/5786b9be9f887ed371c804e786081b476a403104/dom/base/nsFrameLoader.cpp#2272-2290

We should allow the first level of recursion. This is needed by some WPTs:

https://searchfox.org/mozilla-central/rev/5786b9be9f887ed371c804e786081b476a403104/testing/web-platform/tests/feature-policy/resources/featurepolicy.js#98-104

Comment 1

[Andrea Marchesini [:baku]]

Attachment: iframe2.patch

Comment 2

[Andrea Marchesini [:baku]]

Attachment: WPT + tests

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9015187 [details] [diff] [review]
iframe2.patch

Yeah, I think we can increase the limit.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9015202 [details] [diff] [review]
WPT + tests

I'd rather understand why the crashtest starts to timeout

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9015202 [details] [diff] [review]
WPT + tests

ok, I think we'll just get the test fixed.

Comment 6

[Andrea Marchesini [:baku]]

Attachment: WPT + tests

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc46a5f43a47
Allow 1 level of recursion when loading nested iframes with same URL, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/70f63648a0f6
Fix WPTs for 1 level of recursion when loading nested iframes with same URL, r=smaug

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/dc46a5f43a47
https://hg.mozilla.org/mozilla-central/rev/70f63648a0f6