Firefox fails to load nested equal iframes

RESOLVED FIXED in Firefox 64

Status

()

enhancement
RESOLVED FIXED
9 months ago
3 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

(Regressed 1 bug)

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

9 months ago
Firefox blocks the loading of an iframe with the same URL of the current context ignoring the ref parts. This happens because MAX_SAME_URL_CONTENT_FRAMES is set to 1 here:

https://searchfox.org/mozilla-central/rev/5786b9be9f887ed371c804e786081b476a403104/dom/base/nsFrameLoader.cpp#133

and it's used here:

https://searchfox.org/mozilla-central/rev/5786b9be9f887ed371c804e786081b476a403104/dom/base/nsFrameLoader.cpp#2272-2290

We should allow the first level of recursion. This is needed by some WPTs:

https://searchfox.org/mozilla-central/rev/5786b9be9f887ed371c804e786081b476a403104/testing/web-platform/tests/feature-policy/resources/featurepolicy.js#98-104
Assignee

Comment 1

9 months ago
Posted patch iframe2.patchSplinter Review
Attachment #9015187 - Flags: review?(bugs)
Assignee

Updated

9 months ago
Blocks: 1497141
Assignee

Comment 2

9 months ago
Posted patch WPT + tests (obsolete) — Splinter Review
Attachment #9015202 - Flags: review?(bugs)
Comment on attachment 9015187 [details] [diff] [review]
iframe2.patch

Yeah, I think we can increase the limit.
Attachment #9015187 - Flags: review?(bugs) → review+
Comment on attachment 9015202 [details] [diff] [review]
WPT + tests

I'd rather understand why the crashtest starts to timeout
Comment on attachment 9015202 [details] [diff] [review]
WPT + tests

ok, I think we'll just get the test fixed.
Attachment #9015202 - Flags: review?(bugs)
Assignee

Comment 6

9 months ago
Posted patch WPT + testsSplinter Review
Attachment #9015202 - Attachment is obsolete: true
Attachment #9015209 - Flags: review?(bugs)

Updated

9 months ago
Attachment #9015209 - Flags: review?(bugs) → review+

Comment 7

9 months ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc46a5f43a47
Allow 1 level of recursion when loading nested iframes with same URL, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/70f63648a0f6
Fix WPTs for 1 level of recursion when loading nested iframes with same URL, r=smaug

Comment 8

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dc46a5f43a47
https://hg.mozilla.org/mozilla-central/rev/70f63648a0f6
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Depends on: 1503241
Component: DOM → DOM: Core & HTML
No longer depends on: 1503241
Regressions: 1503241
You need to log in before you can comment on or make changes to this bug.