1497169 - ipc/chromium/src/third_party/Unified_c_src_third_party0.o: undefined symbol: arc4random_addrandom

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Jan Beich]

FreeBSD 12.0 dropped arc4random_addrandom() but before that it was deprecated. Given backporting upstream commit would require updating platform configs and downstream package already defaults to --with-system-libevent let's adjust OpenBSD fix.

https://github.com/libevent/libevent/commit/6541168d7037
https://svnweb.freebsd.org/changeset/base/338331
https://svnweb.freebsd.org/changeset/ports/478104

$ c++ -v
FreeBSD clang version 7.0.0 (tags/RELEASE_700/final 342383) (based on LLVM 7.0.0)
Target: x86_64-unknown-freebsd12.0
Thread model: posix
InstalledDir: /usr/bin

$ ./mach bootstrap
$ ./mach build
[...]
13:43.83 ld: error: undefined symbol: arc4random_addrandom
13:43.83 >>> referenced by Unified_c_src_third_party0.c
13:43.83 >>>               ../../ipc/chromium/src/third_party/Unified_c_src_third_party0.o:(evutil_secure_rng_add_bytes)
13:43.97 clang++: error: linker command failed with exit code 1 (use -v to see invocation)
13:43.97 gmake[4]: *** [/tmp/mozilla-central/config/rules.mk:710: libxul.so] Error 1

Comment 1

[Jan Beich]

Attachment: v0

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f416f89f836b71454d547f43516d12fbd7f6afb8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ef3760a29be
Unbreak bundled libevent on FreeBSD 12. r=froydnj

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4ef3760a29be

Comment 4

[Jan Beich]

Comment on attachment 9015218 [details] [diff] [review]
v0

FreeBSD 12.0 release may happen during Firefox 63 life.
https://www.freebsd.org/releases/12.0R/schedule.html


[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: Broken build on FreeBSD 12.0 (or later) unless .mozconfig contains --with-system-libevent.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Can only break build. evutil_secure_rng_add_bytes() is not used by Firefox.

String changes made/needed:

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9015218 [details] [diff] [review]
v0

Sorry, this is too late in the Beta cycle (we build the last 63 beta on Thursday before entering RC) to uplift unplanned tier-3 patches as we need to minimize any potential regression for the final release.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9015218 [details] [diff] [review]
v0

This is NPOTB, we should take this.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a571fb22559a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/97ef270558e0