Closed Bug 1497180 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13419 - Don't switch back to the harness window during testharness tests.

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13419 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13419
Details from upstream follow.

James Graham <james@hoppipolla.co.uk> wrote:
>  Don't switch back to the harness window during testharness tests.
>  
>  Previously we kept switching back and forth between the harness window
>  and the window containing the test as we processed WebDriver
>  callbacks. But this is unnecessary; we can use the fact that we have
>  access to window.opener to set the callback on the opener window and
>  run it there, yes still have it block a WebDriver call in the test
>  window. This means that during the test we can keep the focus on the
>  test window, but put all the complex logic in the parent and retain
>  the ability to close the test window after each test to create a clean
>  environment.
PR 13419 applied with additional changes from upstream: 40421ff058cbf8020878bcb096bf604d1c450aec, 87aced4b630de20060d43f644787d8a7ed042928, cd30ed9c9d86033365e37a76ace1b040e57064b2, b0d2d2da21dfd03e86c5d710c926ae7df3b9f0d0, ceadf71f63047e88dddd9308fd9f06db24ecfb29, f1db6b22cf40d6b56665225dfd4f83bbddd76686, 01dfc0f42edacd529749fcf543e16431ba7a9490, 723dcaffe979639976dee773c09eb24694625c23, a9504407fb46702dbb2bba7df9d349d8eba7ce55
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bde9cf027e1a
[wpt PR 13419] - Don't switch back to the harness window during testharness tests., a=testonly
https://hg.mozilla.org/mozilla-central/rev/bde9cf027e1a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.