1497202 - Apply Meta CSP to about:performance

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P3)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1497202_csp_about_performance.patch

Comment 2

[:Gijs (he/him)]

Comment on attachment 9016272 [details] [diff] [review]
bug_1497202_csp_about_performance.patch

Review of attachment 9016272 [details] [diff] [review]:
-----------------------------------------------------------------

A bunch of this stuff is in flux at the moment. Florian is probably a better reviewer here than me.

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 9016272 [details] [diff] [review]
bug_1497202_csp_about_performance.patch

Review of attachment 9016272 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks. Please land sooner than later, as this will bitrot with the patch I'm preparing for bug 1498185 (I'll rebase it above your patch).

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Florian Quèze [:florian] from comment #3)
> Looks good to me, thanks. Please land sooner than later, as this will bitrot
> with the patch I'm preparing for bug 1498185 (I'll rebase it above your
> patch).

Thanks for the heads up, but this bug is still blocked by the overall re-architecture work in Bug 965637. Please just go ahead and land your things - I'll rebase this patch one un-blocked.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ckerschb, could you have a look please?

Comment 6

[Christoph Kerschbaumer [:ckerschb]]

Before we can apply CSP to system privileged about pages we have to fix Bug 965637, in which we move the CSP from the Principal into the Client. Please note that the Meta Bug 1492063 for applying CSP to system privileged about: pages is blocked by 965637. At the moment we are fixing the last remaining blockers and as soon as we have landed Bug 965637 I'll try to land all the dependencies of Bug 1492063 so we end up having all about: pages secured by a CSP.

Comment 7

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1497202: Apply Meta CSP to about:performance. r=fqueze

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3099eaead3bd
Apply Meta CSP to about:performance.

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/3099eaead3bd