Closed Bug 1497220 Opened 7 years ago Closed 3 years ago

Seeing spinners when tabs are closed by middle-click or rightclick->close tab (probably because tab warming doesnt kick-in)

Categories

(Firefox :: Tabbed Browser, defect, P3)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: mayankleoboy1, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [fxperf:p3])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0 Steps to reproduce: 1. create new profile (no WR) 2. bookmark a bunch of URL's (typically more than the number of your physical cores) 3. in a tab open https://mikeconley.ca/moz/wavey/ 4. Open all the other tabs at once from the bookmarks, such that your CPU is 100% used 5. Go to the rightmost tab/url 6. Using mouse middle click, start closing the tab you are on one-by-one Actual results: Brief spinners If you click on the close "x" button, you dont see spinners. So this means that if you close tab from the "x" button, tab warming is effective. But if you middle click on the tab, warming is not effective Expected results: no spinners. Same behaviour as when you close a tab by clicking on the "x" button of tabs
Component: General → Tabbed Browser
Product: Core → Firefox
see video The first 3-4 tabs are closed using the middle-mouse-click . They all show spinners. The last 2-3 tabs are closed by clicking the "x" button on tabs. They dont show spinners
Flags: needinfo?(mconley)
Additional steps : 1. After you have opend all tabs, you can load your system by using the fiddle: https://jsfiddle.net/159pokym/25/ . Completely load your CPU, and minimize chrome window. 2. Set processcount to a high number like 20-30. This is important, I think. It is easier to repro when each tab you open gets its on process.
Summary: tab warming doesnt seem to be working when tabs are closed by middle click → Seeing spinners when tabs are closed by middle-click of mouse
Allright, much better 100% repro STR.(Might need Windows) 1. Create fresh profile. (No WR) 2. Go to https://lab.hakim.se/checkwave/ 3. Let it do its thing. Enjoy the effect 4. Right click on the page and go to "view page source" 5. Switch to source tab Step A: Close the tab by clicking the "x" button of the tab Step B : Close the tab by middle clicking the tab with mouse (make sure you dont put mouse over the original checkwave tab to ensure that tab doesnt get warmed) Step A : no spinner Step B : brief spinner
https://perfht.ml/2PiPeU8 : Close tab with "x" button https://perfht.ml/2Pki1Yg : close tab with middle click
Is this a regression?
Flags: needinfo?(mayankleoboy1)
I tried a build from 1 year before, and was able to reproduce. So not a recent regression, if it is a regression. Instead of middle-click, you can also right click on tab->close tab This will also show a brief spinner. Was tab-warming by middle-click or right click->close ever implemented? I see bug 1472230 , but not sure what exactly it implemented.
Flags: needinfo?(mayankleoboy1) → needinfo?(dao+bmo)
Summary: Seeing spinners when tabs are closed by middle-click of mouse → Seeing spinners when tabs are closed by middle-click or rightclick->close tab
(In reply to Mayank Bansal from comment #6) > Was tab-warming by middle-click or right click->close ever implemented? I > see bug 1472230 , but not sure what exactly it implemented. Not for the context menu, afaik.
Flags: needinfo?(dao+bmo)
Priority: -- → P3
(Since I have been noticing these spinners since the last 7-10 days only, I think there is a recent regression somewhere... But I dont have the exact STR to repro. This bug is a substitute bug for my actual experience, and has 100% repro. So I filed this)
Thanks for filing, Mayank - sorry for the lack of response. Queueing for fxperf triage.
Flags: needinfo?(mconley)
Whiteboard: [fxperf]
slightly changing the bug title to more clearly reflect the bug
Summary: Seeing spinners when tabs are closed by middle-click or rightclick->close tab → Seeing spinners when tabs are closed by middle-click or rightclick->close tab (probably because tab warming doesnt kick-in)
Whiteboard: [fxperf] → [fxperf:p2]
Whiteboard: [fxperf:p2] → [fxperf:p3]

hey :mconley, do you think this bug can be worked on? From a naive look, this doesnt look like too much work. Just need to hook one more tab close gesture with the tab-warming infrastructure.
I still do see regular spinners while closing tabs with middle click of mouse.

Flags: needinfo?(mconley)

Hi Mayank,

It's unlikely that we'll get to this in the short term, as we're focusing our efforts on start-up performance rather than tab switching performance. When we focus again on tab switching performance and responsiveness, we'll come back to this.

Flags: needinfo?(mconley)

This bug hasnt seen much action. Additionally, my machine is fast enough that I dont see the spinners anymore so i dont know if this bug is reproducible or not.
Fixing for now.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: