1497225 - Hidden address fields lose their asterisks after changing to a Country or Region that requires those fields

Status: VERIFIED FIXED

(Firefox :: WebPayments UI, defect, P1)

Description

[Timea Cernea [:tbabos]]

Attachment: Video of the issue STR v2

[Affected versions]: 
Nightly 64.0a1 

[Affected platforms]:
Platforms: Windows 10 x64

[Preconditions]:
1. Set the pref dom.payments.request.enabled to "true";
2. Make sure you have at least one Shipping Address and one Credit Card saved in your browser.

[Steps to reproduce]:
1. Go to "https://rsolomakhin.github.io/pr/single/" page and click on "Buy".
2. From "Shipping Address" click on "Add".
3. Check the pre-selected Country - in our case it is Romania. Note that the 'State" field will be hidden as expected.
4. Select "United State" from Country or region.
5. Observe "State" field.

[Expected result]:
"State" field should be marked as required - have an asterisk. 

[Actual result]:
The asterisk from the "State" field that is now visible is missing. 

[Note]:
This issue occurs in both Add (only if the preselected country has a hidden address field) and Edit shipping address forms.

It is more visible if its reproduced via the following steps:

1. Add a new shipping address with the Country or Region being "Macau" - only street address field appears, the rest of the address fields are hidden - and save it.
2. Edit the saved address from Macau back to the United States

* The "City", "Zip Code" and "State" have missing asterisks even if they are required to save the address. 

* Bug 1496061 - might as well be a duplicate for this since our Country is always pre-filled with Romania, thus the hidden 'State" field will lose it's asterisk when US is selected.

Comment 2

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1497225 - Update the required asterisk display when changing countries. r?MattN

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cd7b1c3737a
Update the required asterisk display when changing countries. r=sfoster,MattN

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset 8cd7b1c3737a (Bug 1497225) for failures in browser_editAddressDialog.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=209504224&revision=8cd7b1c3737a583e6c3c5e1dc8287d5db61345f3

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=209504224&repo=autoland&lineNumber=4677

Backout: https://hg.mozilla.org/integration/autoland/rev/591fefb0f99c9d50325fe8e4b151aab7e1ba8691

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e736a623e623
Update the required asterisk display when changing countries. r=sfoster,MattN

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e736a623e623

Comment 7

[Timea Cernea [:tbabos]]

Verified - Fixed on latest Nightly 65.0a1 (2018-11-11) (64-bit) on Windows 7/10, Ma OS 10.13 and Ubuntu 16.04.