Closed Bug 1497226 Opened 6 years ago Closed 6 years ago

Rename WebExtensionTargetActor.id and AddonTargetActor.id to addonId

Categories

(DevTools :: Framework, enhancement)

Product:
DevTools
Component:
Framework
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

Bug 1497226 - Rename WebExtensionActor/WebExtensionTargetActor/AddonTargetActor.id to addonId.
46 bytes, text/x-phabricator-request
Details | Review 
Followup to bug 1492265.

Using "id" looks very generic and might easily collide with similar field defined in the parent class (BrowsingContextTargetActor).

So it would be better to renamed this attribute to "addonId".
Summary: Rename WebExtensionTargetActor.id to addonId → Rename WebExtensionTargetActor.id and AddonTargetActor.id to addonId
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80a1352b7cd9
Rename WebExtensionActor/WebExtensionTargetActor/AddonTargetActor.id to addonId. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/80a1352b7cd9
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Assignee: nobody → poirot.alex
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: