Closed Bug 1497261 Opened 7 years ago Closed 7 years ago

Revert parameter rename for INSTALL_ADDON_FROM_URL

Categories

(Firefox :: New Tab Page, defect, P1)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Iteration:
64.3 - Oct 12
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: andreio, Assigned: andreio)

References

Details

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4477
52 bytes, text/x-github-pull-request
Details | Review
In https://github.com/mozilla/activity-stream/commit/47f11743abcea792122a5a1d24e5b6dd370e6cc3 all user action parameters were renamed to `args` because the snippets schema only allows string values for `button_action`. This means that actions and parameters have to be specified separately and having them unified under a single name made it easier to handle. `INSTALL_ADDON_FROM_URL` was only used by CFR and was not updated.
Blocks: 1496167
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 1498314
https://hg.mozilla.org/mozilla-central/rev/45bc3a854dd1
Iteration: --- → 64.3 (Oct 12)
status-firefox64: --- → fixed
Target Milestone: --- → Firefox 64
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: