Open Bug 1497269 Opened 6 years ago Updated 2 years ago

Emit source-updated from ThreadClient and emit it from it instead of TabTarget

Categories

(DevTools :: Framework, enhancement, P2)

enhancement

Tracking

(Not tracked)

People

(Reporter: ochameau, Unassigned)

References

Details

Today, "source-updated" is only used by tests and source map service:
  https://searchfox.org/mozilla-central/search?q=source-updated&case=true&regexp=false&path=

It is just a mapping of "newSource" and "updatedSource" RDP events, sent by the ThreadActor:
* newSource
  https://searchfox.org/mozilla-central/source/devtools/server/actors/thread.js#1872-1886
* updatedSource
  https://searchfox.org/mozilla-central/source/devtools/server/actors/thread.js#1895-1899

But for both events, the Thread actor uses its parent actor ID to make it so that it is like being sent by the Target actor.
But we should rather emit it from the Thread actor as it is sent by it...
newSource is being sent twice, both from the target and the thread actor.
So we could restrict it to be sent from the thread actor.
Send the updatesSource from the thread actor.
And listen from these two events on the thread client, and stop translating these two event from target and either listen for the two events from source map service or do the mapping from ThreadClient.
Severity: normal → enhancement
Priority: -- → P2
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.