[socket-proc] HttpTransactionParent must have its own suspend counter and queue messages

RESOLVED FIXED

Status

()

enhancement
P3
normal
RESOLVED FIXED
8 months ago
2 months ago

People

(Reporter: mayhemer, Assigned: dragana)

Tracking

(Blocks 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 affected)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

8 months ago
Call to HttpTransactionParent::Suspend/Resume must have its own suspend counter.  Any notifications that are received by the parent trans while suspend counter is >0 must be queued.  It may happen that RecvSuspend is received too late on the child and e.g. OnData/OnStop has already been sent - there can be a (valid) race.
Reporter

Comment 1

8 months ago
Working on top of bug 1485355.
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Reporter

Comment 2

8 months ago
No, rather on top of bug 1496464 to save Kershaw some merging and for basing on more complete code.
Depends on: 1496464
No longer depends on: 1485355
Reporter

Comment 3

8 months ago
Posted patch v1 (obsolete) — Splinter Review
Backing up work that's been done.

Updated

8 months ago
Whiteboard: [necko-triaged]

Comment 4

8 months ago
fixing for bonus points
Summary: [scoket-proc] HttpTransactionParent must have its own suspend counter and queue messages → [socket-proc] HttpTransactionParent must have its own suspend counter and queue messages
Reporter

Updated

7 months ago
Priority: P1 → P3
Reporter

Updated

4 months ago
Assignee: honzab.moz → nobody
Status: ASSIGNED → NEW
Assignee

Updated

3 months ago
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:dragana, could you have a look please?

Flags: needinfo?(dd.mozilla)
Assignee

Comment 7

3 months ago

This is a separate project that will not land on m.-c.. I was waiting for rebasing before landing...

Flags: needinfo?(dd.mozilla)
Assignee

Updated

2 months ago
Attachment #9015317 - Attachment is obsolete: true
Assignee

Comment 8

2 months ago
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.