Closed Bug 1497364 Opened 3 years ago Closed 3 years ago

Allow browser_ext_themes_dynamic_getCurrent.js to continue working if linux focus becomes more async than it already is

Categories

(WebExtensions :: General, defect)

Product:
WebExtensions
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1497364 - allow browser_ext_themes_dynamic_getCurrent.js to work if window focus becomes more async, r?aswan
46 bytes, text/x-phabricator-request
Details | Review 
browser_ext_themes_dynamic_getCurrent.js depends on focus switching more or less sycnhronously to the window created with browser.windows.create().

Especially after about:blank creation changes in the browser window, this isn't guaranteed to be the case. The test should check focus has changed explicitly to avoid race conditions.
See Also: → 1492480
Blocks: 1496360
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f624eab87210
allow browser_ext_themes_dynamic_getCurrent.js to work if window focus becomes more async, r=aswan
https://hg.mozilla.org/mozilla-central/rev/f624eab87210
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Will this bug require manual testing? if so please specify some steps to validate or set the 'qe-verify-' flag, thank you
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Vlad Jiman from comment #4)
> Will this bug require manual testing? if so please specify some steps to
> validate or set the 'qe-verify-' flag, thank you

This is a change that only affects an automated test.
Flags: needinfo?(gijskruitbosch+bugs) → qe-verify-
(In reply to :Gijs (he/him) from comment #5)
> (In reply to Vlad Jiman from comment #4)
> > Will this bug require manual testing? if so please specify some steps to
> > validate or set the 'qe-verify-' flag, thank you
> 
> This is a change that only affects an automated test.

Thank you.
You need to log in before you can comment on or make changes to this bug.