Closed Bug 1497376 Opened 11 months ago Closed 11 months ago

[wpt-sync] Sync PR 13427 - [LayoutNG] Auto top/bottom margins may resolve to negative values.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13427 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13427
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:
>  [LayoutNG] Auto top/bottom margins may resolve to negative values.
>  
>  The spec doesn't say that auto margin-top or margin-bottom need to
>  resolve to something non-negative, so just allow negative values as
>  well. They don't cause over-constrainedness.
>  
>  Also, when distributing the space to margin-top and margin-bottom, make
>  sure that everything gets distributed. Set margin-top to the half, and
>  set margin-bottom to total space MINUS margin-top. Just dividing both by
>  two might cause us to lose a tiny fraction of the total, due to rounding.
>  
>  Bug: 888270
>  Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
>  Change-Id: Ia10577851e60707a0e2d67857a1c43a12e28b9d2
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1269855
>  WPT-Export-Revision: afd10c99d330686aeeb3c7178eaf0b0b37743452
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d8a90abecca
[wpt PR 13427] - [LayoutNG] Auto top/bottom margins may resolve to negative values., a=testonly
https://hg.mozilla.org/mozilla-central/rev/0d8a90abecca
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.