1497412 - string URLs - change handling of status variable

Status: RESOLVED DUPLICATE of bug 1501356

(Webtools Graveyard :: Pontoon, defect)

Description

[Djfe]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

Someone send me the link to a string:
https://pontoon.mozilla.org/de/firefox/all-resources/?status=missing&string=190589


Actual results:

I opened it, but Pontoon only redirects me to the file and not the string with the id, even though the string still exists under that ID.


Expected results:

Treat "status" differently.
If the string doesn't exist with that status, then show a list with all strings of that status plus the string with the id from the variable "string" (regardless of it's status)

This also helps, if you approve a string and then reload the page with F5 -> the string stays selected.

Comment 1

[Matjaz Horvat [:mathjazz]]

Phew, I'm not sure about this one.

The status parameter always comes before the string parameter in the URL, so one would expect it to win.

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

That would be a pretty big change in the way the Translate page works. At the moment, it is a search interface, so everything is the result of a set of parameters, and incidentally you see strings when there are results for those parameters. The `string` parameter in the URL is just a bonus right now, so that the correct string is opened by default. Fun fact, if we wanted to make the URL quite correct, it should use a hash for the string parameter, like so: pontoon/de/firefox/all/?status=missing#!string=190589 (because the string number is actually never used in the server, it only serves in the client).

I don't think it makes any sense to change the Translate page to be a string-first interface. However, it is possible that we can find different solutions. One of them, proposed by Pike in IRC, would be to create permalinks to a string in the Translate page. That would be a hack on top of the existing. 

We could create a new view just to see specific strings, with direct links (/string/locale/string_id/ for example), but I'm not sure that would actually be very useful. 

Overall, I believe addressing this would require a substantial amount of work for very little benefits. I thus am in favor of not fixing this.

Comment 3

[Matjaz Horvat [:mathjazz]]

Filed bug 1501356 to track the permalink feature.