Closed
Bug 1497419
Opened 7 years ago
Closed 6 years ago
Diff view ($compare) does not seem to handle RTL consistently between content and metadata
Categories
(developer.mozilla.org Graveyard :: Design, enhancement, P5)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: sphinx_knight, Unassigned)
Details
(Keywords: in-triage, Whiteboard: [specification][type:bug][points:1])
Attachments
(2 files)
Screenshot of the mentioned page with rev. numbers highlighted
What did you do?
================
1. Checked an edit with https://developer.mozilla.org/ar/docs/Glossary/%D8%A7%D9%84%D9%83%D8%A7%D8%A6%D9%86%D8%A7%D8%AA$compare?locale=ar&to=1424179&from=847397
2. Wondered how to read this since I'm not a RTL-language speaker/writer
What happened?
==============
The metadata "region" of the page displays info about rev. 847397 on the left and 1424179 on the right.
On the other hand, the "content-diffing" region displays info about rev. 1424179 on the left and about rev. 847397 on the right.
What should have happened?
==========================
With respect to RTL, I think the revisions medata/content should not be "mixed".
Is there anything else we should know?
======================================
- I'm no RTL-writer/speaker so I might totally be wrong here as I don't know the rules that apply
|
||
Comment 2•7 years ago
|
||
Sphinx, what does wikipedia do?
For Wikipedia, the newer revision is displayed on the left side and the older revision on the right. There is no "mix" between the metadata and content afterwards.
(URL for ref:https://ar.wikipedia.org/w/index.php?title=%D8%A5%D9%86%D8%AA%D8%B1%D9%86%D8%AA_%D8%A5%D9%83%D8%B3%D8%A8%D9%84%D9%88%D8%B1%D8%B1&type=revision&diff=30883654&oldid=29800990)
Flags: needinfo?(sphinx_knight)
|
||
Comment 4•7 years ago
|
||
Thanks Julien, I misread your report the first few times. I'm not sure if the order of the earlier and later revisions should also change in RTL languages, but I agree it should be consistent between the metadata and the diff.
MDN's three RTL languages are ar (Arabic), fa (Persian), and he (Hebrew). Arabic appears to be the most common. I'd love an opinion from an Arabic speaker if they expect the most recent on the left, like English and left-to-right languages, or the most recent on the right. I'm adding a needinfo for Pontoon's ar manager, صفا الفليج.
Without an expert opinion, I'm inclined to use the Revision Dashboard as a guide, which has more RTL attention. The Arabic version appears to consistently have text aligned to the right, and the diffs have the earlier revision on the right side:
https://developer.mozilla.org/ar/dashboards/revisions?locale=ar&user=&topic=&start_date=&end_date=&preceding_period=&authors=0&page=1
I think this means the metadata needs to swap (earlier on the right), and the diff stay the same.
Flags: needinfo?(safa1996alfulaij)
|
||
Comment 5•7 years ago
|
||
Thanks John for reaching to me!
You are right. the metadata needs to be swapped. I believe that it was a leftover when supporting RTL, while both the content items are supported correctly. (It is actually a table that gets mirrored with dir=rtl)
A simple:
.revision-diff .rev-from {float: right;} // was: left
.revision-diff .rev-to {float: left;} // was: right
was more than enough to fix this. html[dir=rtl] should not be forgotten, of course :)
Flags: needinfo?(safa1996alfulaij)
|
|
||
Comment 6•7 years ago
|
||
Thanks Safa. It looks like <html dir=rtl> is already applied.
It looks like those rules are defined at:
https://github.com/mozilla/kuma/blob/6d15902235c4e2bd95fd8d3a29b2084d297ff346/kuma/static/styles/diff.scss
The bidi mixin looks like the technique for switching a value based html[dir='rtl']:
https://github.com/mozilla/kuma/blob/dd88c15a651071d3615b953337095135f45bdb95/kuma/static/styles/includes/_mixins.scss#L328-L371
We're still leaving this unassigned, but maybe this is enough for a contributor to pick it up.
Whiteboard: [specification][type:bug] → [specification][type:bug][points:1]
|
||
Comment 7•6 years ago
|
||
MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
|
|
||
Updated•6 years ago
|
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•