Closed Bug 1497439 Opened 6 years ago Closed 6 years ago

Assert in ANGLE during webgl-conf instanced-rendering-large-divisor.html

Categories

(Core :: Graphics: CanvasWebGL, enhancement)

Product:
Core
Component:
Graphics: CanvasWebGL
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

(Whiteboard: gfx-noted) 

Sounds like we're just not truncating right before sending to the driver.
> [generated/test_2_conformance2__rendering__instanced-rendering-large-divisor.html]
> # Assertion failed: static_cast<unsigned int>(packedAttrib.divisor) == divisor, file z:/build/build/src/gfx/angle/checkout/src/libANGLE/renderer/d3d/d3d11/InputLayoutCache.cpp, line 89
> skip-if = (os == 'win')
Olli fixed this three weeks ago:
https://github.com/google/angle/commit/0131ff4018
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0be6d75ba4a3
Revendor ANGLE with cherry-pick for large vert attrib divisors.
https://hg.mozilla.org/mozilla-central/rev/0be6d75ba4a3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.