Closed Bug 1497467 Opened 4 years ago Closed 4 years ago

Convert AddonClient to protocol.js front

Categories

(DevTools :: Framework, enhancement, P2)

enhancement

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission)

Attachments

(1 file, 1 obsolete file)

AddonClient is the client class to connect to Target actors like AddonTargetActor.
We should convert that client class to a protocol.js front.

It is going to help later merge TabTarget into such front (bug 1465635)

AddonClient is currently only created from attachThread over here:
https://searchfox.org/mozilla-central/rev/29aea2a2a3bd0f5e25ce0b60a76053fb25ba5149/devtools/client/framework/attach-thread.js#101-103
      target.client.attachAddon(actor).then(([res]) => {
        target.client.attachThread(res.threadActor).then(handleResponse);
      });
This is the `res` object over here.
At the end, we don't call any of this client method, we only retrieve its `threadActor` property.
Instead, here, we should call `attach()` on the front and also possibly "attach the addon target front" (client.attachAddon) from TabTarget rather than attachThread. That would better match what we are doing for other targets.
Depends on: 1497470
Severity: normal → enhancement
Priority: -- → P2
Whiteboard: dt-fission
Assignee: nobody → poirot.alex
MozReview-Commit-ID: 78Oqsq4mGqW
MozReview-Commit-ID: 78Oqsq4mGqW
Attachment #9021563 - Attachment is obsolete: true
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/423f407d58bb
Convert AddonClient to protocol.js front. r=yulia
https://hg.mozilla.org/mozilla-central/rev/423f407d58bb
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.