1497467 - Convert AddonClient to protocol.js front

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

AddonClient is the client class to connect to Target actors like AddonTargetActor.
We should convert that client class to a protocol.js front.

It is going to help later merge TabTarget into such front (bug 1465635)

AddonClient is currently only created from attachThread over here:
https://searchfox.org/mozilla-central/rev/29aea2a2a3bd0f5e25ce0b60a76053fb25ba5149/devtools/client/framework/attach-thread.js#101-103
      target.client.attachAddon(actor).then(([res]) => {
        target.client.attachThread(res.threadActor).then(handleResponse);
      });
This is the `res` object over here.
At the end, we don't call any of this client method, we only retrieve its `threadActor` property.
Instead, here, we should call `attach()` on the front and also possibly "attach the addon target front" (client.attachAddon) from TabTarget rather than attachThread. That would better match what we are doing for other targets.

Comment 1

[Alexandre Poirot [:ochameau]]

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6650a462a5659a99b897e0d69c09c261618aeaec

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1497467 - Convert AddonClient to protocol.js front.

MozReview-Commit-ID: 78Oqsq4mGqW

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1497467 - Convert AddonClient to protocol.js front.

MozReview-Commit-ID: 78Oqsq4mGqW

Comment 4

[Alexandre Poirot [:ochameau]]

New try run:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=645df8f2a714b8213330939fcc7e9316f5d1e185

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/423f407d58bb
Convert AddonClient to protocol.js front. r=yulia

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/423f407d58bb