Closed
Bug 1497503
Opened 6 years ago
Closed 6 years ago
Add `locales` to [[paths]] in project config and compare-locales
Categories
(Localization Infrastructure and Tools :: compare-locales, enhancement)
Localization Infrastructure and Tools
compare-locales
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: Pike)
Details
Attachments
(1 file)
1.14 KB,
patch
|
flod
:
review+
|
Details | Diff | Splinter Review |
We should add support for `locales` in `[[paths]]`, to enable a particular directory only for a subset of locales. The specified list of locales is assumed to be a subset.
Assignee | ||
Comment 1•6 years ago
|
||
Turns out compare-locales can already do that. I was confused by the docs stating otherwise, so fixing the docs. Code in c-l: https://phabricator.services.mozilla.com/source/compare-locales/browse/default/compare_locales/paths/configparser.py$81-82 https://phabricator.services.mozilla.com/source/compare-locales/browse/default/compare_locales/paths/project.py$63-64 https://phabricator.services.mozilla.com/source/compare-locales/browse/default/compare_locales/paths/files.py$31-35 https://phabricator.services.mozilla.com/source/compare-locales/browse/default/compare_locales/tests/paths/test_files.py$120-163
Attachment #9015530 -
Flags: review?(francesco.lodolo)
Comment 2•6 years ago
|
||
Comment on attachment 9015530 [details] [diff] [review] documentation Review of attachment 9015530 [details] [diff] [review]: ----------------------------------------------------------------- ::: docs/fileformat.rst @@ +98,5 @@ > For bilingual file formats, it's acceptable to just specify the ``l10n`` path, > though it's encouraged to define the ``reference`` to enable more tests. > > +To limit a particular path pattern to a subset of locales, you can specify > +an option ``locales`` entry: option -> optional? The latter seems more natural
Attachment #9015530 -
Flags: review?(francesco.lodolo) → review+
Assignee | ||
Comment 3•6 years ago
|
||
Documentation fixed. Also, local setup fixed, which I hadn't done yet after we created the /l10n/ upstream repo, including adjusting the config of rtd to actually point to the official location.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•