Closed Bug 1497545 Opened 11 months ago Closed 10 months ago

Use target.getFront in tests in devtools/server/tests/mochitest

Categories

(DevTools :: General, enhancement)

enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: yulia, Assigned: yulia)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission)

Attachments

(6 files)

We need to migrate these front instantiations to getFront wherever possible: https://searchfox.org/mozilla-central/search?q=.*Front%5C(&case=false&regexp=true&path=devtools%2Fserver%2Ftests%2Fmochitest
Blocks: 1485383
This is part 1 of bug 1497545, and covers the most difficult case, which is migrating
attachURL to something a bit more modern and easier to read. The goal is to make our tests more
consistant with our code base now, and keep these tests maintainable.
This patch converts all getInspector locations

Depends on D8369
In this patch, I converted the call sites where there was an obvious target. I left out
those where there wasn't one... Should these be converted as well?

Depends on D8369
Summary: Use target.getFront in tests in devtools/server/tests/browser → Use target.getFront in tests in devtools/server/tests/mochitest
Depends on D8374
Depends on D8542
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb7c1a49aa0f
update inspector-helper attachURL to provide a target; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/2ed2e01ecdef
Use getInspector in devtools/server/tests/mochitest r=ochameau
https://hg.mozilla.org/integration/autoland/rev/229ac4221d11
remove client and cleanup from attachURL; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/fb835f0cd5b6
Use getFront for Framerate Front where possible; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/78b8e67c7e59
clean up framerate tests; r=ochameau
Flags: qe-verify-
Whiteboard: dt-fission
You need to log in before you can comment on or make changes to this bug.