Closed Bug 1497577 Opened 11 months ago Closed 10 months ago
Upstream code to detect zero size windows in desktop capture
47 bytes, text/x-phabricator-request
|Details | Review|
We have code that detects zero size windows that can probably be upstreamed: https://searchfox.org/mozilla-central/rev/80ac71c1c54af788b32e851192dfd2de2ec18e18/media/webrtc/trunk/webrtc/modules/desktop_capture/mac/window_list_utils.cc#49 https://searchfox.org/mozilla-central/rev/80ac71c1c54af788b32e851192dfd2de2ec18e18/media/webrtc/trunk/webrtc/modules/desktop_capture/window_capturer_win.cc#82
There will also be similar code in media/webrtc/trunk/webrtc/modules/desktop_capture/x11/window_list_utils.cc once the branch 64 update lands.
Assignee: nobody → dminor
Status: NEW → ASSIGNED
This was added by Bug 1196542. I've filed https://bugs.chromium.org/p/webrtc/issues/detail?id=10058 upstream.
Upstream review: https://webrtc-review.googlesource.com/c/src/+/112182
I think this change  that landed after the changes were made in Bug 1196542 would remove the need for this patch on Windows, which is as far as I know, the only platform where we had problems with zero size windows. I'm going to test this on try.  https://chromium-review.googlesource.com/c/external/webrtc/+/634383/4/webrtc/modules/desktop_capture/window_capturer_win.cc#189
Try run for the removal: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f3b06549ea4d1d1e147b22248af9515a3568602
This code was added by Bug 1196542 to fix a permanently failing test on our Windows test machines. After this landed, upstream added a check for empty windows in window_captuer_win.cc, so this should no longer be a problem on Windows. As far as I know, this was never a problem on the other platforms, so this code can be safely removed.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/647ade4da0fb Remove code to detect zero size windows; r=ng
You need to log in before you can comment on or make changes to this bug.