Closed Bug 1497577 Opened 11 months ago Closed 10 months ago

Upstream code to detect zero size windows in desktop capture

Categories

(Core :: WebRTC: Audio/Video, enhancement, P3)

63 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

There will also be similar code in media/webrtc/trunk/webrtc/modules/desktop_capture/x11/window_list_utils.cc once the branch 64 update lands.
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Rank: 25
This was added by Bug 1196542.

I've filed https://bugs.chromium.org/p/webrtc/issues/detail?id=10058 upstream.
I think this change [1] that landed after the changes were made in Bug 1196542 would remove the need for this patch on Windows, which is as far as I know, the only platform where we had problems with zero size windows. I'm going to test this on try.

[1] https://chromium-review.googlesource.com/c/external/webrtc/+/634383/4/webrtc/modules/desktop_capture/window_capturer_win.cc#189
This code was added by Bug 1196542 to fix a permanently failing test on our
Windows test machines. After this landed, upstream added a check for empty
windows in window_captuer_win.cc, so this should no longer be a problem on
Windows. As far as I know, this was never a problem on the other platforms,
so this code can be safely removed.
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/647ade4da0fb
Remove code to detect zero size windows; r=ng
https://hg.mozilla.org/mozilla-central/rev/647ade4da0fb
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.