1497644 - Ensure that RootClient is used for all requests made to the root actor

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Siblings of bug 1485671 but for the RootClient.

There is a couple of places where we request the root actor manually, by using DebuggerServerConnection.send():
https://searchfox.org/mozilla-central/search?q=to%3A+%22root%22&case=false&regexp=false&path=

Instead, all these requests should be done via RootClient:
  client.mainRoot.theRequest()

So that it is later easier to convert RootClient to a front.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1497644 - Always call Root actor's getProcess request via RootClient.getProcess

I also made its argument mandatory, so that later in root spec we can use a non-nullable number.

MozReview-Commit-ID: BUPgI1ww1gC

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1497644 - Ensure that RootClient is used for all requests made to the root actor.

MozReview-Commit-ID: HJm7yQCMbkg

Depends on D8141

Comment 3

[Alexandre Poirot [:ochameau]]

Try run:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=abe861fac8a9baa9ecd5d9bc3e75e80722174717

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1497644 - Always call Root actor's getProcess request via RootClient.getProcess

I also made its argument mandatory, so that later in root spec we can use a non-nullable number.

MozReview-Commit-ID: BUPgI1ww1gC

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1497644 - Ensure that RootClient is used for all requests made to the root actor.

MozReview-Commit-ID: HJm7yQCMbkg

Depends on D8361

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b6dac8e39db
Always call Root actor's getProcess request via RootClient.getProcess r=yulia
https://hg.mozilla.org/integration/autoland/rev/eaf50a59155d
Ensure that RootClient is used for all requests made to the root actor. r=yulia

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9b6dac8e39db
https://hg.mozilla.org/mozilla-central/rev/eaf50a59155d