Closed Bug 1497644 Opened 2 years ago Closed 2 years ago

Ensure that RootClient is used for all requests made to the root actor

Categories

(DevTools :: Framework, enhancement)

enhancement
Not set
normal

Tracking

(firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

(Whiteboard: dt-fission)

Attachments

(2 files, 2 obsolete files)

Siblings of bug 1485671 but for the RootClient.

There is a couple of places where we request the root actor manually, by using DebuggerServerConnection.send():
https://searchfox.org/mozilla-central/search?q=to%3A+%22root%22&case=false&regexp=false&path=

Instead, all these requests should be done via RootClient:
  client.mainRoot.theRequest()

So that it is later easier to convert RootClient to a front.
Assignee: nobody → poirot.alex
I also made its argument mandatory, so that later in root spec we can use a non-nullable number.

MozReview-Commit-ID: BUPgI1ww1gC
MozReview-Commit-ID: HJm7yQCMbkg

Depends on D8141
I also made its argument mandatory, so that later in root spec we can use a non-nullable number.

MozReview-Commit-ID: BUPgI1ww1gC
MozReview-Commit-ID: HJm7yQCMbkg

Depends on D8361
Attachment #9016207 - Attachment is obsolete: true
Attachment #9016206 - Attachment is obsolete: true
Blocks: 1498280
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b6dac8e39db
Always call Root actor's getProcess request via RootClient.getProcess r=yulia
https://hg.mozilla.org/integration/autoland/rev/eaf50a59155d
Ensure that RootClient is used for all requests made to the root actor. r=yulia
https://hg.mozilla.org/mozilla-central/rev/9b6dac8e39db
https://hg.mozilla.org/mozilla-central/rev/eaf50a59155d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Whiteboard: dt-fission
You need to log in before you can comment on or make changes to this bug.