1497658 - Stop using GetCurrentJSContext in nsGlobalWindowOuter

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Remove a useless GetCurrentJSContext check in MakeScriptDialogTitle

We want to just use the subject principal URI.  In practice, all our callers
are script anyway, it turns out...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Stop using GetCurrentJSContext in CallerInnerWindow

We're always called from script, so just pass through the JSContext.

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 9015672 [details] [diff] [review]
part  2.  Stop using GetCurrentJSContext in CallerInnerWindow

Review of attachment 9015672 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindowOuter.h
@@ +807,5 @@
>  
>    inline void MaybeClearInnerWindow(nsGlobalWindowInner* aExpectedInner);
>  
> +  // We need a JSContext to get prototypes inside CallerInnerWindow.
> +  nsGlobalWindowInner *CallerInnerWindow(JSContext* aCx);

nit: * on the return value should be to the left.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b635e6611d12
part 1.  Remove a useless GetCurrentJSContext check in MakeScriptDialogTitle.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/296fa4a869ae
part  2.  Stop using GetCurrentJSContext in CallerInnerWindow.  r=mccr8

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b635e6611d12
https://hg.mozilla.org/mozilla-central/rev/296fa4a869ae