Closed Bug 1497784 Opened 5 years ago Closed 5 years ago

[BinAST] Lexical scope is not handled properly

Categories

(Core :: JavaScript Engine, defect, P3)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox64 --- disabled
firefox65 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(2 files, 1 obsolete file)

let.binjs
397 bytes, application/octet-stream
Details
Drop support for lexical declaration in BinAST for now. r=Yoric
13.29 KB, patch
Yoric
: review+
Details | Diff | Splinter Review
Attached file let.binjs — 
encoded from
for (let i = 0; i < 3; i++) {}

tested on m-c 6f8701d1be0c + patches for other bug fixes under bug 1495611

Configure flags: --enable-warnings-as-errors --disable-optimize --enable-debug

Runtime flag: -B let.binjs

actual result:
SyntaxError: BinAST Parsing Error: Missing variable in AssertedScope
See Also: → 1498101
let's disable for now, in order to focus on ES5 feature.
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Attachment #9019578 - Flags: review?(dteller)
Attachment #9019578 - Flags: review?(dteller) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/916db80793cbefc667b019edefeb83559c535b50
Bug 1497784 - Drop support for lexical declaration in BinAST for now. r=Yoric
Backed out for /_mozilla/binast/large.https.html failures.

backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/6e4537056d5363fc118fa946615955798892314b

push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&searchStr=wpt&revision=916db80793cbefc667b019edefeb83559c535b50&selectedJob=208527939

failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=208526184&repo=mozilla-inbound&lineNumber=9343

[task 2018-10-30T01:49:03.865Z] 01:49:03     INFO - TEST-START | /_mozilla/binast/large.https.html
[task 2018-10-30T01:49:03.865Z] 01:49:03     INFO - Clearing pref dom.script_loader.binast_encoding.enabled
[task 2018-10-30T01:49:03.909Z] 01:49:03     INFO - Setting pref dom.script_loader.binast_encoding.enabled (true)
[task 2018-10-30T01:49:04.088Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2011
[task 2018-10-30T01:49:04.088Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2011
[task 2018-10-30T01:49:04.195Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2127
[task 2018-10-30T01:49:04.196Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2127
[task 2018-10-30T01:49:04.197Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2127
[task 2018-10-30T01:49:04.197Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2127
[task 2018-10-30T01:49:04.197Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2127
[task 2018-10-30T01:49:04.198Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2127
[task 2018-10-30T01:49:04.200Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2127
[task 2018-10-30T01:49:04.200Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2127
[task 2018-10-30T01:49:04.201Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2127
[task 2018-10-30T01:49:04.202Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2127
[task 2018-10-30T01:49:04.204Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2127
[task 2018-10-30T01:49:04.204Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2127
[task 2018-10-30T01:49:04.204Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2127
[task 2018-10-30T01:49:04.205Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2127
[task 2018-10-30T01:49:04.221Z] 01:49:04     INFO - PID 13146 | ++DOMWINDOW == 12 (0x7f0ba92af800) [pid = 13252] [serial = 12] [outer = 0x7f0bc5355c00]
[task 2018-10-30T01:49:04.383Z] 01:49:04     INFO - PID 13146 | ++DOCSHELL 0x7f0ba92cb000 == 4 [pid = 13252] [id = {25d2570b-1607-4a6c-b977-43eed13cedf1}]
[task 2018-10-30T01:49:04.383Z] 01:49:04     INFO - PID 13146 | [Child 13252, Main Thread] WARNING: NS_ENSURE_TRUE(browserChrome) failed: file /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp, line 12597
[task 2018-10-30T01:49:04.384Z] 01:49:04     INFO - PID 13146 | ++DOMWINDOW == 13 (0x7f0bad913e00) [pid = 13252] [serial = 13] [outer = (nil)]
[task 2018-10-30T01:49:04.405Z] 01:49:04     INFO - PID 13146 | ++DOMWINDOW == 14 (0x7f0ba92b6400) [pid = 13252] [serial = 14] [outer = 0x7f0bad913e00]
[task 2018-10-30T01:49:04.502Z] 01:49:04     INFO - PID 13146 | ++DOMWINDOW == 15 (0x7f0bad5a0c00) [pid = 13252] [serial = 15] [outer = 0x7f0bad913e00]
[task 2018-10-30T01:49:04.721Z] 01:49:04     INFO - PID 13146 | Assertion failure: reader_.cx_->isExceptionPending(), at /builds/worker/workspace/build/src/js/src/frontend/BinTokenReaderMultipart.cpp:435
[task 2018-10-30T01:49:04.802Z] 01:49:04     INFO - PID 13146 | [Parent 13146, Gecko_IOThread] WARNING: pipe error (96): Connection reset by peer: file /builds/worker/workspace/build/src/ipc/chromium/src/chrome/common/ipc_channel_posix.cc, line
ask 2018-10-30T01:49:07.755Z] 01:49:07     INFO - PID 13146 | --DOCSHELL 0x7f7fe9152800 == 0 [pid = 13146] [id = {9e5eb17e-acf7-464d-9bc6-40c2f4bdc140}]
[task 2018-10-30T01:49:07.756Z] 01:49:07     INFO - PID 13146 | --DOMWINDOW == 5 (0x7f7fe7e0d800) [pid = 13146] [serial = 17] [outer = (nil)] [url = chrome://extensions/content/dummy.xul]
[task 2018-10-30T01:49:07.756Z] 01:49:07     INFO - PID 13146 | --DOMWINDOW == 4 (0x7f7fe702dc00) [pid = 13146] [serial = 21] [outer = (nil)] [url = about:blank]
[task 2018-10-30T01:49:07.757Z] 01:49:07     INFO - PID 13146 | --DOMWINDOW == 3 (0x7f7ff6d4bc00) [pid = 13146] [serial = 20] [outer = (nil)] [url = about:blank]
[task 2018-10-30T01:49:07.758Z] 01:49:07     INFO - PID 13146 | --DOMWINDOW == 2 (0x7f7fea7c4400) [pid = 13146] [serial = 5] [outer = (nil)] [url = resource://gre-resources/hiddenWindow.html]
[task 2018-10-30T01:49:07.758Z] 01:49:07     INFO - PID 13146 | --DOMWINDOW == 1 (0x7f7fea7b9800) [pid = 13146] [serial = 4] [outer = (nil)] [url = about:blank]
[task 2018-10-30T01:49:07.759Z] 01:49:07     INFO - PID 13146 | --DOMWINDOW == 0 (0x7f7fe7022400) [pid = 13146] [serial = 27] [outer = (nil)] [url = about:tabcrashed?e=tabcrashed&u=https%3A//web-platform.test%3A8443/_mozilla/binast/large.https.html&c=UTF-8&f=regular&d=Check%20whether%20we%20can%20load%20large%20BinAST%20file]
[task 2018-10-30T01:49:07.817Z] 01:49:07     INFO - PID 13146 | nsStringStats
[task 2018-10-30T01:49:07.817Z] 01:49:07     INFO - PID 13146 |  => mAllocCount:          79915
[task 2018-10-30T01:49:07.817Z] 01:49:07     INFO - PID 13146 |  => mReallocCount:            0
[task 2018-10-30T01:49:07.818Z] 01:49:07     INFO - PID 13146 |  => mFreeCount:           79914  --  LEAKED 1 !!!
[task 2018-10-30T01:49:07.818Z] 01:49:07     INFO - PID 13146 |  => mShareCount:          78797
[task 2018-10-30T01:49:07.818Z] 01:49:07     INFO - PID 13146 |  => mAdoptCount:           3244
[task 2018-10-30T01:49:07.818Z] 01:49:07     INFO - PID 13146 |  => mAdoptFreeCount:       3316
[task 2018-10-30T01:49:07.818Z] 01:49:07     INFO - PID 13146 |  => Process ID: 13146, Thread ID: 140187919378240
[task 2018-10-30T01:49:13.087Z] 01:49:13     INFO - mozcrash Copy/paste: /usr/local/bin/linux64-minidump_stackwalk /tmp/tmpwtWkOt.mozrunner/minidumps/450e0218-2bb8-cd6f-b74c-ed179e92ed18.dmp /tmp/tmp15oMyw
[task 2018-10-30T01:49:23.478Z] 01:49:23     INFO - mozcrash Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/450e0218-2bb8-cd6f-b74c-ed179e92ed18.dmp
[task 2018-10-30T01:49:23.478Z] 01:49:23     INFO - mozcrash Saved app info as /builds/worker/workspace/build/blobber_upload_dir/450e0218-2bb8-cd6f-b74c-ed179e92ed18.extra
[task 2018-10-30T01:49:23.622Z] 01:49:23     INFO - TEST-UNEXPECTED-CRASH | /_mozilla/binast/large.https.html | expected OK
[task 2018-10-30T01:49:23.623Z] 01:49:23     INFO - TEST-INFO took 19759ms
[task 2018-10-30T01:49:23.641Z] 01:49:23     INFO - Closing logging queue
[task 2018-10-30T01:49:23.642Z] 01:49:23     INFO - queue closed
[task 2018-10-30T01:49:23.663Z] 01:49:23     INFO - Setting up ssl
[task 2018-10-30T01:49:23.699Z] 01:49:23     INFO - certutil | 
[task 2018-10-30T01:49:23.737Z] 01:49:23     INFO - certutil | 
[task 2018-10-30T01:49:23.758Z] 01:49:23     INFO - certutil | 
[task 2018-10-30T01:49:23.758Z] 01:49:23     INFO - Certificate Nickname                                         Trust Attributes
[task 2018-10-30T01:49:23.758Z] 01:49:23     INFO -                                                              SSL,S/MIME,JAR/XPI
[task 2018-10-30T01:49:23.759Z] 01:49:23     INFO - 
[task 2018-10-30T01:49:23.759Z] 01:49:23     INFO - web-platform-tests                                           CT,, 
[task 2018-10-30T01:49:23.759Z] 01:49:23     INFO - 
[task 2018-10-30T01:49:23.800Z] 01:49:23     INFO - Application command: /builds/worker/workspace/build/application/firefox/firefox --marionette about:blank -profile /tmp/tmp5rQr_x.mozrunner
[task 2018-10-30T01:49:23.821Z] 01:49:23     INFO - Starting runner
[task 2018-10-30T01:49:25.363Z] 01:49:25     INFO - PID 13359 | 1540864165353	addons.webextension.screenshots@mozilla.org	WARN	Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid host permission: resource://pdf.js/
[task 2018-10-30T01:49:25.363Z] 01:49:25     INFO - PID 13359 | 1540864165354	addons.webextension.screenshots@mozilla.org	WARN	Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid host permission: about:reader*
[task 2018-10-30T01:49:25.868Z] 01:49:25     INFO - PID 13359 | [13359, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file /builds/worker/workspace/build/src/netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 342
[task 2018-10-30T01:49:25.872Z] 01:49:25     INFO - PID 13359 | [13359, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file /builds/worker/workspace/build/src/netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 342
[task 2018-10-30T01:49:25.880Z] 01:49:25     INFO - PID 13359 | [13359, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file /builds/worker/workspace/build/src/netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 342
[task 2018-10-30T01:49:25.884Z] 01:49:25     INFO - PID 13359 | [13359, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file /builds/worker/workspace/build/src/netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 342
Flags: needinfo?(arai.unmht)
Depends on: 1503142
* removed let_in_fun.js testcase from jsapi-test
  * changed wpt test to use var instead of const
Attachment #9019578 - Attachment is obsolete: true
Flags: needinfo?(arai.unmht)
Attachment #9021064 - Flags: review?(dteller)
Attachment #9021064 - Flags: review?(dteller) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4fb56d2819e636de6c7ae756028e537efae48d0
Bug 1497784 - Drop support for lexical declaration in BinAST for now. r=Yoric
https://hg.mozilla.org/mozilla-central/rev/a4fb56d2819e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.