1497793 - moz-phab returns WindowsError: [Error 2] The system cannot find the file specified on windows when running self-update

Status: RESOLVED INCOMPLETE

(Conduit :: moz-phab, defect)

Description

[Florin Strugariu [:Bebe]]

When running moz-phab on windows I get a windows error

florin.strugariu@SVROLP00068 /c/mozilla-source/mozilla-central
$ arc --version
arcanist 2650e8627a20e1bfe334a4a2b787f44ef5d6ebc5 (14 Sep 2018)
libphutil 603209bb1756ef9ad3409aaca96d8e6ade72a937 (8 Oct 2018)

florin.strugariu@SVROLP00068 /c/mozilla-source/mozilla-central
$ moz-phab -v
usage: moz-phab [-h] COMMAND ...
moz-phab: error: too few arguments

florin.strugariu@SVROLP00068 /c/mozilla-source/mozilla-central
$ moz-phab -h
usage: moz-phab [-h] COMMAND ...

positional arguments:
  COMMAND
    submit     Submit commits(s) to Phabricator
    self-update
               Update review script

optional arguments:
  -h, --help   show this help message and exit

florin.strugariu@SVROLP00068 /c/mozilla-source/mozilla-central
$ moz-phab self-update
WindowsError: [Error 2] The system cannot find the file specified

Comment 1

[Florin Strugariu [:Bebe]]

from my investigation I found:
https://bugs.python.org/issue17023

Looks like  subprocess.check_call(command, **kwargs) is not handling the path as is should.
https://github.com/mozilla-conduit/review/blob/master/moz-phab#L176 


Created pull request:
https://github.com/mozilla-conduit/review/pull/6

Comment 2

[Florin Strugariu [:Bebe]]

:glob can you review this please

Comment 3

[:glob ✱]

reviewed, but that isn't the approach we should be taking.  (note using phabricator for reviews is preferred).

can you please set the DEBUG environment variable, re-run `moz-phab self-update`, and attach the full output to this bug.
> DEBUG=1 moz-phab self-update

Comment 4

[Florin Strugariu [:Bebe]]

$ DEBUG=1 moz-phab self-update
updating c:/Users/florin.strugariu\.moz-phab-config
$ arc upgrade
Traceback (most recent call last):
  File "c:/Users/florin.strugariu/phabricator/moz-phab", line 1506, in main
    args.func(args)
  File "c:/Users/florin.strugariu/phabricator/moz-phab", line 1339, in self_update
    update_arc()
  File "c:/Users/florin.strugariu/phabricator/moz-phab", line 1305, in update_arc
    check_call(config.arc + ["upgrade"])
  File "c:/Users/florin.strugariu/phabricator/moz-phab", line 176, in check_call
    subprocess.check_call(command, **kwargs)
  File "c:\mozilla-build\python\lib\subprocess.py", line 185, in check_call
    retcode = call(*popenargs, **kwargs)
  File "c:\mozilla-build\python\lib\subprocess.py", line 172, in call
    return Popen(*popenargs, **kwargs).wait()
  File "c:\mozilla-build\python\lib\subprocess.py", line 394, in __init__
    errread, errwrite)
  File "c:\mozilla-build\python\lib\subprocess.py", line 644, in _execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified

Comment 5

[Florin Strugariu [:Bebe]]

also I get the same result when running moz-phab submit

$ DEBUG=1 moz-phab submit de5d769adef17b8d000b2752f826d849cf37f8e0
found hg repo in c:\mozilla-source\mozilla-central
$ hg.exe --version --quiet
Mercurial Distributed SCM (version 4.7.2)
$ hg.exe config
$ hg.exe --config 'ui.username=florin.strugariu <[e-mail]>' --config extensions.rebase= --config experimental.evolution.createmarkers=true --config extensions.strip= log -T '{node}\n' -r de5d769adef17b8d000b2752f826d849cf37f8e0
de5d769adef17b8d000b2752f826d849cf37f8e0
$ hg.exe --config 'ui.username=florin.strugariu <[e-mail]>' --config extensions.rebase= --config experimental.evolution.createmarkers=true --config extensions.strip= log -T '{node}\n' -r .
de5d769adef17b8d000b2752f826d849cf37f8e0
$ hg.exe --config 'ui.username=florin.strugariu <[e-mail]>' --config extensions.rebase= --config experimental.evolution.createmarkers=true --config extensions.strip= log -T '{rev} {node} {desc}--1af25602190249d7be3eaafa801ce6e1--\n' -r de5d769adef1::de5d769adef1
440119 de5d769adef17b8d000b2752f826d849cf37f8e0 Bug 1336409 Use https://hg.mozilla.org instead of http in talos r=jmaher--1af25602190249d7be3eaafa801ce6e1--

Submitting 1 commit:
440119:de5d769adef1 Bug 1336409 Use https://hg.mozilla.org instead of http in talos r?jmaher
$ hg.exe --config 'ui.username=florin.strugariu <[e-mail]>' --config extensions.rebase= --config experimental.evolution.createmarkers=true --config extensions.strip= log -T '{node}\n' -r 'ancestor(de5d769adef1::de5d769adef1)'
de5d769adef17b8d000b2752f826d849cf37f8e0
$ hg.exe --config 'ui.username=florin.strugariu <[e-mail]>' --config extensions.rebase= --config experimental.evolution.createmarkers=true --config extensions.strip= log -T '{phase} {node}\n' -r 'parents(de5d769adef17b8d000b2752f826d849cf37f8e0)'
draft 078b88af8fd1b3eb3ce14cb2f4f0cb9e41f79178
de5d769adef1 is based off non-public commit 078b88af8fd1
$ hg.exe --config 'ui.username=florin.strugariu <[e-mail]>' --config extensions.rebase= --config experimental.evolution.createmarkers=true --config extensions.strip= log -T '{node}\n' -r 'de5d769adef1::de5d769adef1 and merge()'
$ hg.exe --config 'ui.username=florin.strugariu <[e-mail]>' --config extensions.rebase= --config experimental.evolution.createmarkers=true --config extensions.strip= status --added --deleted --modified --unknown
Submit to Phabricator (YES/No/Always)? YES

Creating new revision:
440119:de5d769adef1 Bug 1336409 Use https://hg.mozilla.org instead of http in talos r?jmaher
$ hg.exe --config 'ui.username=florin.strugariu <[e-mail]>' --config extensions.rebase= --config experimental.evolution.createmarkers=true --config extensions.strip= update --quiet de5d769adef17b8d000b2752f826d849cf37f8e0
--- arc message
Bug 1336409 Use https://hg.mozilla.org instead of http in talos r?jmaher

Summary:




Test Plan:

Reviewers: jmaher

Subscribers:

Bug #: 1336409
---
$ arc --trace diff --base arc:this --allow-untracked --no-amend --no-ansi --message-file 'c:\users\florin~1.str\appdata\local\temp\tmpbavilm' --create
Traceback (most recent call last):
  File "c:/Users/florin.strugariu/phabricator/moz-phab", line 1510, in main
    args.func(repo, args)
  File "c:/Users/florin.strugariu/phabricator/moz-phab", line 1233, in submit
    arc_output = arc_out(arc_args, cwd=repo.path)
  File "c:/Users/florin.strugariu/phabricator/moz-phab", line 1087, in arc_out
    arc_output = check_output(config.arc + args, cwd=cwd, split=False)
  File "c:/Users/florin.strugariu/phabricator/moz-phab", line 183, in check_output
    output = subprocess.check_output(command, cwd=cwd)
  File "c:\mozilla-build\python\lib\subprocess.py", line 216, in check_output
    process = Popen(stdout=PIPE, *popenargs, **kwargs)
  File "c:\mozilla-build\python\lib\subprocess.py", line 394, in __init__
    errread, errwrite)
  File "c:\mozilla-build\python\lib\subprocess.py", line 644, in _execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified

Comment 6

[Mark Côté [:mcote]]

Does running "arc help" from a terminal work correctly?

Comment 7

[Mark Côté [:mcote]]

Oh wait sorry, I just saw that arc seems to work.  What shell are you using?  MSYS (e.g. MozillaBuild)?  If so, can you run "which arc"?

Comment 8

[Florin Strugariu [:Bebe]]

arc works as it should:
>$ which arc
>/c/Users/florin.strugariu/phabricator/arcanist/bin/arc

I'm able to run 'arc diff' to submit code for review.

Comment 9

[:glob ✱]

can you check your ~/.moz-phab-config file for me please?
the `arc_command` property should be set to `arc.bat`.

if it's currently just `arc`, please update to `arc.bat` and try again:
> [arc]
> arc_command = arc.bat

if this works please rename or delete your ~/.moz-phab-config file and run moz-phab (without args is ok).
moz-phab should automatically re-generate the file - i'd like to know if that new config file also has `arc` instead of `arc.bat`.

Comment 10

[:glob ✱]

closing bug as stale.  there's been some changes around how we call arc which may have addressed this issue, and as i can't reproduce this issue there isn't much i can do without feedback from :bebe.