Closed Bug 1497827 Opened 6 years ago Closed 5 years ago

Do not display EV labels instead of domains in site identity header

Categories

(Firefox :: Site Identity, defect, P3)

Product:
Firefox
Component:
Site Identity
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: johannh, Assigned: manishkk, Mentored)

References

Details

Attachments

(3 files, 3 obsolete files)

Screenshot 2018-10-10 at 12.12.06.png
137.62 KB, image/png
Details
Bug 1497827 Do not display EV labels instead of domains in site identity header r?johannh
47 bytes, text/x-phabricator-request
Details | Review
Bug 1497827 - Do not display EV labels instead of domains in site identity header
47 bytes, text/x-phabricator-request
Details | Review 
We used to show the EV label instead of the domain in the old control center hostname label, but now with the new header, "Site Information for Mozilla Corporation" makes a lot less sense than "Site Information for mozilla.org". Given the prominent position of the EV indicator, I don't think this is a big loss for EV sites.
Assignee: nobody → 1991manish.kumar

Are you still working on this, Manish? :)

Mentor: jhofmann
Status: NEW → ASSIGNED
Flags: needinfo?(1991manish.kumar)

If someone else wants to work on this, please assign to them.
Else I will work on this weekend.

Flags: needinfo?(1991manish.kumar)
Attachment #9036214 - Attachment is obsolete: true
Attachment #9036215 - Attachment is obsolete: true

Try seems good, landing now...

Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e7c60e83b86
Do not display EV labels instead of domains in site identity header r=johannh

Backed out for perma failing at testing/firefox-ui/tests/functional/security/test_ev_certificate.py.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=1e7c60e83b86e18d1c7918d2e4b2fd5d4d79fde2

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=222170268&repo=autoland&lineNumber=6572

01:55:54 INFO - 1547632554437 Marionette DEBUG 10 <- [1,136,null,{"value":"<html><head>\n <meta name="viewport" content="width=device-width, initial-scale=1">\n <link rel=\ ... org/wiki/Extended_Validation_Certificate">Extended Validation</a>) digital certificate.\n \n</div>\n\n\n\n</body></html>"}]
01:55:54 INFO - 1547632554439 Marionette DEBUG 10 -> [0,137,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554440 Marionette DEBUG 10 <- [1,137,null,{"value":null}]
01:55:54 INFO - TEST-UNEXPECTED-FAIL | testing/firefox-ui/tests/functional/security/test_ev_certificate.py TestEVCertificate.test_ev_certificate | AssertionError: u'Site Information for extended-validation.badssl.com' != u'Site Information for Mozilla Foundation'
01:55:54 INFO - - Site Information for extended-validation.badssl.com
01:55:54 INFO - + Site Information for Mozilla Foundation
01:55:54 INFO - Traceback (most recent call last):
01:55:54 INFO - File "/Users/cltbld/tasks/task_1547627233/build/venv/lib/python2.7/site-packages/marionette_harness/marionette_test/testcases.py", line 159, in run
01:55:54 INFO - testMethod()
01:55:54 INFO - File "/Users/cltbld/tasks/task_1547627233/build/tests/firefox-ui/tests/testing/firefox-ui/tests/functional/security/test_ev_certificate.py", line 56, in test_ev_certificate
01:55:54 INFO - l10n_header)
01:55:54 INFO - TEST-INFO took 1941ms
01:55:54 INFO - 1547632554442 Marionette DEBUG 10 -> [0,138,"WebDriver:GetChromeWindowHandles",{}]
01:55:54 INFO - 1547632554443 Marionette DEBUG 10 <- [1,138,null,["3"]]
01:55:54 INFO - 1547632554445 Marionette DEBUG 10 -> [0,139,"WebDriver:SwitchToWindow",{"focus":true,"name":"3"}]
01:55:54 INFO - 1547632554446 Marionette DEBUG 10 <- [1,139,null,{"value":null}]
01:55:54 INFO - 1547632554447 Marionette DEBUG 10 -> [0,140,"WebDriver:GetChromeWindowHandle",{}]
01:55:54 INFO - 1547632554448 Marionette DEBUG 10 <- [1,140,null,{"value":"3"}]
01:55:54 INFO - 1547632554449 Marionette DEBUG 10 -> [0,141,"Marionette:GetContext",{}]
01:55:54 INFO - 1547632554449 Marionette DEBUG 10 <- [1,141,null,{"value":"chrome"}]
01:55:54 INFO - 1547632554451 Marionette DEBUG 10 -> [0,142,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554451 Marionette DEBUG 10 <- [1,142,null,{"value":null}]
01:55:54 INFO - 1547632554453 Marionette DEBUG 10 -> [0,143,"WebDriver:GetChromeWindowHandle",{}]
01:55:54 INFO - 1547632554453 Marionette DEBUG 10 <- [1,143,null,{"value":"3"}]
01:55:54 INFO - 1547632554454 Marionette DEBUG 10 -> [0,144,"Marionette:GetWindowType",{}]
01:55:54 INFO - 1547632554455 Marionette DEBUG 10 <- [1,144,null,{"value":"navigator:browser"}]
01:55:54 INFO - 1547632554456 Marionette DEBUG 10 -> [0,145,"WebDriver:GetChromeWindowHandles",{}]
01:55:54 INFO - 1547632554457 Marionette DEBUG 10 <- [1,145,null,["3"]]
01:55:54 INFO - 1547632554458 Marionette DEBUG 10 -> [0,146,"Marionette:GetContext",{}]
01:55:54 INFO - 1547632554459 Marionette DEBUG 10 <- [1,146,null,{"value":"chrome"}]
01:55:54 INFO - 1547632554461 Marionette DEBUG 10 -> [0,147,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554462 Marionette DEBUG 10 <- [1,147,null,{"value":null}]
01:55:54 INFO - 1547632554464 Marionette DEBUG 10 -> [0,148,"WebDriver:ExecuteScript",{"script":"Components.utils.import("resource://gre/modules/Services.jsm");\n\n ... s":["3"],"filename":"../../venv/lib/python2.7/site-packages/firefox_puppeteer/ui/windows.py","sandbox":"default","line":157}]
01:55:54 INFO - 1547632554469 Marionette DEBUG 10 <- [1,148,null,{"value":true}]
01:55:54 INFO - 1547632554471 Marionette DEBUG 10 -> [0,149,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554472 Marionette DEBUG 10 <- [1,149,null,{"value":null}]
01:55:54 INFO - 1547632554473 Marionette DEBUG 10 -> [0,150,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554474 Marionette DEBUG 10 <- [1,150,null,{"value":null}]
01:55:54 INFO - 1547632554475 Marionette DEBUG 10 -> [0,151,"WebDriver:GetElementProperty",{"id":"3aab17db-a0f3-024f-b2f2-2b1d7222a7f3","name":"state"}]
01:55:54 INFO - 1547632554476 Marionette DEBUG 10 <- [1,151,null,{"value":"open"}]
01:55:54 INFO - 1547632554478 Marionette DEBUG 10 -> [0,152,"WebDriver:ExecuteScript",{"script":"arguments[0].hidePopup();","newSandbox":true,"args":[{"element-6066-11e4-a52e-4f7 ... "filename":"../../venv/lib/python2.7/site-packages/firefox_puppeteer/ui/browser/toolbars.py","sandbox":"default","line":440}]
01:55:54 INFO - 1547632554490 Marionette DEBUG 10 <- [1,152,null,{"value":null}]
01:55:54 INFO - 1547632554507 Marionette DEBUG 10 -> [0,153,"WebDriver:GetElementProperty",{"id":"3aab17db-a0f3-024f-b2f2-2b1d7222a7f3","name":"state"}]
01:55:54 INFO - 1547632554508 Marionette DEBUG 10 <- [1,153,null,{"value":"closed"}]
01:55:54 INFO - 1547632554509 Marionette DEBUG 10 -> [0,154,"WebDriver:GetChromeWindowHandles",{}]
01:55:54 INFO - 1547632554510 Marionette DEBUG 10 <- [1,154,null,["3"]]
01:55:54 INFO - 1547632554511 Marionette DEBUG 10 -> [0,155,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554512 Marionette DEBUG 10 <- [1,155,null,{"value":null}]
01:55:54 INFO - 1547632554513 Marionette DEBUG 10 -> [0,156,"WebDriver:GetWindowHandles",{}]
01:55:54 INFO - 1547632554514 Marionette DEBUG 10 <- [1,156,null,["32212254721"]]
01:55:54 INFO - 1547632554516 Marionette DEBUG 10 -> [0,157,"WebDriver:GetChromeWindowHandles",{}]
01:55:54 INFO - 1547632554516 Marionette DEBUG 10 <- [1,157,null,["3"]]
01:55:54 INFO - 1547632554518 Marionette DEBUG 10 -> [0,158,"WebDriver:GetChromeWindowHandles",{}]
01:55:54 INFO - 1547632554520 Marionette DEBUG 10 <- [1,158,null,["3"]]
01:55:54 INFO - 1547632554524 Marionette DEBUG 10 -> [0,159,"WebDriver:GetChromeWindowHandles",{}]
01:55:54 INFO - 1547632554525 Marionette DEBUG 10 <- [1,159,null,["3"]]
01:55:54 INFO - 1547632554526 Marionette DEBUG 10 -> [0,160,"WebDriver:SwitchToWindow",{"focus":true,"name":"3"}]
01:55:54 INFO - 1547632554527 Marionette DEBUG 10 <- [1,160,null,{"value":null}]
01:55:54 INFO - 1547632554529 Marionette DEBUG 10 -> [0,161,"WebDriver:GetChromeWindowHandle",{}]
01:55:54 INFO - 1547632554529 Marionette DEBUG 10 <- [1,161,null,{"value":"3"}]
01:55:54 INFO - 1547632554531 Marionette DEBUG 10 -> [0,162,"Marionette:GetContext",{}]
01:55:54 INFO - 1547632554532 Marionette DEBUG 10 <- [1,162,null,{"value":"chrome"}]
01:55:54 INFO - 1547632554533 Marionette DEBUG 10 -> [0,163,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554534 Marionette DEBUG 10 <- [1,163,null,{"value":null}]
01:55:54 INFO - 1547632554538 Marionette DEBUG 10 -> [0,164,"WebDriver:GetChromeWindowHandle",{}]
01:55:54 INFO - 1547632554539 Marionette DEBUG 10 <- [1,164,null,{"value":"3"}]
01:55:54 INFO - 1547632554541 Marionette DEBUG 10 -> [0,165,"Marionette:GetWindowType",{}]
01:55:54 INFO - 1547632554541 Marionette DEBUG 10 <- [1,165,null,{"value":"navigator:browser"}]
01:55:54 INFO - 1547632554543 Marionette DEBUG 10 -> [0,166,"WebDriver:GetChromeWindowHandles",{}]
01:55:54 INFO - 1547632554544 Marionette DEBUG 10 <- [1,166,null,["3"]]
01:55:54 INFO - 1547632554546 Marionette DEBUG 10 -> [0,167,"Marionette:GetContext",{}]
01:55:54 INFO - 1547632554547 Marionette DEBUG 10 <- [1,167,null,{"value":"chrome"}]
01:55:54 INFO - 1547632554548 Marionette DEBUG 10 -> [0,168,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554549 Marionette DEBUG 10 <- [1,168,null,{"value":null}]
01:55:54 INFO - 1547632554553 Marionette DEBUG 10 -> [0,169,"WebDriver:ExecuteScript",{"script":"Components.utils.import("resource://gre/modules/Services.jsm");\n\n ... s":["3"],"filename":"../../venv/lib/python2.7/site-packages/firefox_puppeteer/ui/windows.py","sandbox":"default","line":157}]
01:55:54 INFO - 1547632554558 Marionette DEBUG 10 <- [1,169,null,{"value":true}]
01:55:54 INFO - 1547632554560 Marionette DEBUG 10 -> [0,170,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554561 Marionette DEBUG 10 <- [1,170,null,{"value":null}]
01:55:54 INFO - 1547632554563 Marionette DEBUG 10 -> [0,171,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554563 Marionette DEBUG 10 <- [1,171,null,{"value":null}]
01:55:54 INFO - 1547632554565 Marionette DEBUG 10 -> [0,172,"Marionette:GetContext",{}]
01:55:54 INFO - 1547632554566 Marionette DEBUG 10 <- [1,172,null,{"value":"chrome"}]
01:55:54 INFO - 1547632554570 Marionette DEBUG 10 -> [0,173,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554571 Marionette DEBUG 10 <- [1,173,null,{"value":null}]
01:55:54 INFO - 1547632554573 Marionette DEBUG 10 -> [0,174,"WebDriver:ExecuteScript",{"script":"window.focus();","newSandbox":true,"args":[],"filename":"../../venv/lib/python2.7/site-packages/firefox_puppeteer/ui/windows.py","sandbox":"default","line":138}]
01:55:54 INFO - 1547632554577 Marionette DEBUG 10 <- [1,174,null,{"value":null}]
01:55:54 INFO - 1547632554579 Marionette DEBUG 10 -> [0,175,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554580 Marionette DEBUG 10 <- [1,175,null,{"value":null}]
01:55:54 INFO - 1547632554581 Marionette DEBUG 10 -> [0,176,"Marionette:GetContext",{}]
01:55:54 INFO - 1547632554582 Marionette DEBUG 10 <- [1,176,null,{"value":"chrome"}]
01:55:54 INFO - 1547632554584 Marionette DEBUG 10 -> [0,177,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554584 Marionette DEBUG 10 <- [1,177,null,{"value":null}]
01:55:54 INFO - 1547632554589 Marionette DEBUG 10 -> [0,178,"WebDriver:ExecuteScript",{"script":"Components.utils.import("resource://gre/modules/Services.jsm");\n\n ... "args":[],"filename":"../../venv/lib/python2.7/site-packages/firefox_puppeteer/ui/windows.py","sandbox":"default","line":59}]
01:55:54 INFO - 1547632554593 Marionette DEBUG 10 <- [1,178,null,{"value":"3"}]
01:55:54 INFO - 1547632554595 Marionette DEBUG 10 -> [0,179,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554596 Marionette DEBUG 10 <- [1,179,null,{"value":null}]
01:55:54 INFO - 1547632554597 Marionette DEBUG 10 -> [0,180,"WebDriver:GetChromeWindowHandles",{}]
01:55:54 INFO - 1547632554598 Marionette DEBUG 10 <- [1,180,null,["3"]]
01:55:54 INFO - 1547632554600 Marionette DEBUG 10 -> [0,181,"WebDriver:SwitchToWindow",{"focus":true,"name":"3"}]
01:55:54 INFO - 1547632554601 Marionette DEBUG 10 <- [1,181,null,{"value":null}]
01:55:54 INFO - 1547632554605 Marionette DEBUG 10 -> [0,182,"WebDriver:GetChromeWindowHandle",{}]
01:55:54 INFO - 1547632554606 Marionette DEBUG 10 <- [1,182,null,{"value":"3"}]
01:55:54 INFO - 1547632554608 Marionette DEBUG 10 -> [0,183,"Marionette:GetContext",{}]
01:55:54 INFO - 1547632554608 Marionette DEBUG 10 <- [1,183,null,{"value":"chrome"}]
01:55:54 INFO - 1547632554610 Marionette DEBUG 10 -> [0,184,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554611 Marionette DEBUG 10 <- [1,184,null,{"value":null}]
01:55:54 INFO - 1547632554612 Marionette DEBUG 10 -> [0,185,"WebDriver:GetChromeWindowHandle",{}]
01:55:54 INFO - 1547632554613 Marionette DEBUG 10 <- [1,185,null,{"value":"3"}]
01:55:54 INFO - 1547632554615 Marionette DEBUG 10 -> [0,186,"Marionette:GetWindowType",{}]
01:55:54 INFO - 1547632554616 Marionette DEBUG 10 <- [1,186,null,{"value":"navigator:browser"}]
01:55:54 INFO - 1547632554620 Marionette DEBUG 10 -> [0,187,"WebDriver:GetChromeWindowHandles",{}]
01:55:54 INFO - 1547632554621 Marionette DEBUG 10 <- [1,187,null,["3"]]
01:55:54 INFO - 1547632554622 Marionette DEBUG 10 -> [0,188,"Marionette:GetContext",{}]
01:55:54 INFO - 1547632554623 Marionette DEBUG 10 <- [1,188,null,{"value":"chrome"}]
01:55:54 INFO - 1547632554624 Marionette DEBUG 10 -> [0,189,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554625 Marionette DEBUG 10 <- [1,189,null,{"value":null}]
01:55:54 INFO - 1547632554627 Marionette DEBUG 10 -> [0,190,"WebDriver:ExecuteScript",{"script":"Components.utils.import("resource://gre/modules/Services.jsm");\n\n ... s":["3"],"filename":"../../venv/lib/python2.7/site-packages/firefox_puppeteer/ui/windows.py","sandbox":"default","line":157}]
01:55:54 INFO - 1547632554632 Marionette DEBUG 10 <- [1,190,null,{"value":true}]
01:55:54 INFO - 1547632554633 Marionette DEBUG 10 -> [0,191,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554634 Marionette DEBUG 10 <- [1,191,null,{"value":null}]
01:55:54 INFO - 1547632554639 Marionette DEBUG 10 -> [0,192,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554640 Marionette DEBUG 10 <- [1,192,null,{"value":null}]
01:55:54 INFO - 1547632554641 Marionette DEBUG 10 -> [0,193,"WebDriver:GetChromeWindowHandles",{}]
01:55:54 INFO - 1547632554642 Marionette DEBUG 10 <- [1,193,null,["3"]]
01:55:54 INFO - 1547632554644 Marionette DEBUG 10 -> [0,194,"WebDriver:SwitchToWindow",{"focus":true,"name":"3"}]
01:55:54 INFO - 1547632554646 Marionette DEBUG 10 <- [1,194,null,{"value":null}]
01:55:54 INFO - 1547632554648 Marionette DEBUG 10 -> [0,195,"WebDriver:GetChromeWindowHandle",{}]
01:55:54 INFO - 1547632554649 Marionette DEBUG 10 <- [1,195,null,{"value":"3"}]
01:55:54 INFO - 1547632554654 Marionette DEBUG 10 -> [0,196,"Marionette:GetContext",{}]
01:55:54 INFO - 1547632554655 Marionette DEBUG 10 <- [1,196,null,{"value":"chrome"}]
01:55:54 INFO - 1547632554657 Marionette DEBUG 10 -> [0,197,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554658 Marionette DEBUG 10 <- [1,197,null,{"value":null}]
01:55:54 INFO - 1547632554660 Marionette DEBUG 10 -> [0,198,"WebDriver:GetChromeWindowHandle",{}]
01:55:54 INFO - 1547632554661 Marionette DEBUG 10 <- [1,198,null,{"value":"3"}]
01:55:54 INFO - 1547632554663 Marionette DEBUG 10 -> [0,199,"Marionette:GetWindowType",{}]
01:55:54 INFO - 1547632554664 Marionette DEBUG 10 <- [1,199,null,{"value":"navigator:browser"}]
01:55:54 INFO - 1547632554666 Marionette DEBUG 10 -> [0,200,"WebDriver:GetChromeWindowHandles",{}]
01:55:54 INFO - 1547632554668 Marionette DEBUG 10 <- [1,200,null,["3"]]
01:55:54 INFO - 1547632554673 Marionette DEBUG 10 -> [0,201,"Marionette:GetContext",{}]
01:55:54 INFO - 1547632554674 Marionette DEBUG 10 <- [1,201,null,{"value":"chrome"}]
01:55:54 INFO - 1547632554676 Marionette DEBUG 10 -> [0,202,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554678 Marionette DEBUG 10 <- [1,202,null,{"value":null}]
01:55:54 INFO - 1547632554680 Marionette DEBUG 10 -> [0,203,"WebDriver:ExecuteScript",{"script":"Components.utils.import("resource://gre/modules/Services.jsm");\n\n ... s":["3"],"filename":"../../venv/lib/python2.7/site-packages/firefox_puppeteer/ui/windows.py","sandbox":"default","line":157}]
01:55:54 INFO - 1547632554687 Marionette DEBUG 10 <- [1,203,null,{"value":true}]
01:55:54 INFO - 1547632554693 Marionette DEBUG 10 -> [0,204,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554694 Marionette DEBUG 10 <- [1,204,null,{"value":null}]
01:55:54 INFO - 1547632554696 Marionette DEBUG 10 -> [0,205,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554697 Marionette DEBUG 10 <- [1,205,null,{"value":null}]
01:55:54 INFO - 1547632554700 Marionette DEBUG 10 -> [0,206,"WebDriver:FindElements",{"using":"tag name","value":"tab","element":"1fc0f314-691e-a745-b84d-0f4c6ab51f35"}]
01:55:54 INFO - 1547632554703 Marionette DEBUG 10 <- [1,206,null,[{"chromeelement-9fc5-4b51-a3c8-01716eedeb04":"760cc63c-f264-3d4c-905d-6eb6715c6734"}]]
01:55:54 INFO - 1547632554706 Marionette DEBUG 10 -> [0,207,"WebDriver:FindElements",{"using":"tag name","value":"tab","element":"1fc0f314-691e-a745-b84d-0f4c6ab51f35"}]
01:55:54 INFO - 1547632554709 Marionette DEBUG 10 <- [1,207,null,[{"chromeelement-9fc5-4b51-a3c8-01716eedeb04":"760cc63c-f264-3d4c-905d-6eb6715c6734"}]]
01:55:54 INFO - 1547632554712 Marionette DEBUG 10 -> [0,208,"WebDriver:ExecuteScript",{"script":"let browser = arguments[0].linkedBrowser;\n if (!browser || browser.oute ... ],"filename":"../../venv/lib/python2.7/site-packages/firefox_puppeteer/ui/browser/tabbar.py","sandbox":"default","line":214}]
01:55:54 INFO - 1547632554719 Marionette DEBUG 10 <- [1,208,null,{"value":"32212254721"}]
01:55:54 INFO - 1547632554722 Marionette DEBUG 10 -> [0,209,"WebDriver:ExecuteScript",{"script":"let browser = arguments[0].linkedBrowser;\n if (!browser || browser.oute ... ],"filename":"../../venv/lib/python2.7/site-packages/firefox_puppeteer/ui/browser/tabbar.py","sandbox":"default","line":214}]
01:55:54 INFO - 1547632554729 Marionette DEBUG 10 <- [1,209,null,{"value":"32212254721"}]
01:55:54 INFO - 1547632554731 Marionette DEBUG 10 -> [0,210,"WebDriver:GetChromeWindowHandles",{}]
01:55:54 INFO - 1547632554733 Marionette DEBUG 10 <- [1,210,null,["3"]]
01:55:54 INFO - 1547632554735 Marionette DEBUG 10 -> [0,211,"WebDriver:SwitchToWindow",{"focus":true,"name":"3"}]
01:55:54 INFO - 1547632554737 Marionette DEBUG 10 <- [1,211,null,{"value":null}]
01:55:54 INFO - 1547632554739 Marionette DEBUG 10 -> [0,212,"WebDriver:GetChromeWindowHandle",{}]
01:55:54 INFO - 1547632554740 Marionette DEBUG 10 <- [1,212,null,{"value":"3"}]
01:55:54 INFO - 1547632554742 Marionette DEBUG 10 -> [0,213,"Marionette:GetContext",{}]
01:55:54 INFO - 1547632554744 Marionette DEBUG 10 <- [1,213,null,{"value":"chrome"}]
01:55:54 INFO - 1547632554745 Marionette DEBUG 10 -> [0,214,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554746 Marionette DEBUG 10 <- [1,214,null,{"value":null}]
01:55:54 INFO - 1547632554748 Marionette DEBUG 10 -> [0,215,"WebDriver:GetChromeWindowHandle",{}]
01:55:54 INFO - 1547632554749 Marionette DEBUG 10 <- [1,215,null,{"value":"3"}]
01:55:54 INFO - 1547632554752 Marionette DEBUG 10 -> [0,216,"Marionette:GetWindowType",{}]
01:55:54 INFO - 1547632554753 Marionette DEBUG 10 <- [1,216,null,{"value":"navigator:browser"}]
01:55:54 INFO - 1547632554755 Marionette DEBUG 10 -> [0,217,"WebDriver:GetChromeWindowHandles",{}]
01:55:54 INFO - 1547632554756 Marionette DEBUG 10 <- [1,217,null,["3"]]
01:55:54 INFO - 1547632554758 Marionette DEBUG 10 -> [0,218,"Marionette:GetContext",{}]
01:55:54 INFO - 1547632554759 Marionette DEBUG 10 <- [1,218,null,{"value":"chrome"}]
01:55:54 INFO - 1547632554762 Marionette DEBUG 10 -> [0,219,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554763 Marionette DEBUG 10 <- [1,219,null,{"value":null}]
01:55:54 INFO - 1547632554765 Marionette DEBUG 10 -> [0,220,"WebDriver:ExecuteScript",{"script":"Components.utils.import("resource://gre/modules/Services.jsm");\n\n ... s":["3"],"filename":"../../venv/lib/python2.7/site-packages/firefox_puppeteer/ui/windows.py","sandbox":"default","line":157}]
01:55:54 INFO - 1547632554772 Marionette DEBUG 10 <- [1,220,null,{"value":true}]
01:55:54 INFO - 1547632554774 Marionette DEBUG 10 -> [0,221,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554775 Marionette DEBUG 10 <- [1,221,null,{"value":null}]
01:55:54 INFO - 1547632554778 Marionette DEBUG 10 -> [0,222,"Marionette:SetContext",{"value":"chrome"}]
01:55:54 INFO - 1547632554779 Marionette DEBUG 10 <- [1,222,null,{"value":null}]
01:55:54 INFO - 1547632554780 Marionette DEBUG 10 -> [0,223,"WebDriver:FindElements",{"using":"tag name","value":"tab","element":"1fc0f314-691e-a745-b84d-0f4c6ab51f35"}]
01:55:54 INFO - 1547632554784 Marionette DEBUG 10 <- [1,223,null,[{"chromeelement-9fc5-4b51-a3c8-01716eedeb04":"760cc63c-f264-3d4c-905d-6eb6715c6734"}]]
01:55:54 INFO - 1547632554787 Marionette DEBUG 10 -> [0,224,"WebDriver:ExecuteScript",{"script":"let browser = arguments[0].linkedBrowser;\n if (!browser || browser.oute ... ],"filename":"../../venv/lib/python2.7/site-packages/firefox_puppeteer/ui/browser/tabbar.py","sandbox":"default","line":214}]
01:55:54 INFO - 1547632554794 Marionette DEBUG 10 <- [1,224,null,{"value":"32212254721"}]
01:55:54 INFO - 1547632554810 Marionette DEBUG 10 -> [0,225,"WebDriver:SwitchToWindow",{"focus":true,"name":"32212254721"}]
01:55:54 INFO - 1547632554812 Marionette DEBUG 10 <- [1,225,null,{"value":null}]
01:55:54 INFO - 1547632554825 Marionette DEBUG 10 -> [0,226,"WebDriver:DeleteSession",{}]
01:55:54 INFO - 1547632554828 Marionette DEBUG 10 <- [1,226,null,{"value":null}]

Backout: https://hg.mozilla.org/integration/autoland/rev/a56825e2ea2c5b1a2ffb15c813d5d699475f98dc

Flags: needinfo?(1991manish.kumar)

Hi Manish, sorry, my try run didn't cover the functional UI tests written in Python. One of them is failing because it was checking that the identity popup displayed the EV owner where you removed it.

I think the failure is here:

https://searchfox.org/mozilla-central/rev/dac799c9f4e9f5f05c1071cba94f2522aa31f7eb/testing/firefox-ui/tests/functional/security/test_ev_certificate.py#52-56

Would you like to try and correct that?

You can run the test locally with

./mach test testing/firefox-ui/tests/functional/security/test_ev_certificate.py

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8674f81adea9894772170a05b2ab8483975a830

Flags: needinfo?(1991manish.kumar) → needinfo?(jhofmann)

(In reply to Manish [:manishkk] from comment #12)

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8674f81adea9894772170a05b2ab8483975a830

Thanks for fixing this up, unfortunately to run these functional tests you'll need to add the test suite to your try command, e.g.

./mach try -b do -p linux64,macosx64,win64 -u firefox-ui-functional,mochitests -t none
Flags: needinfo?(jhofmann)
Keywords: checkin-needed
Attachment #9041390 - Attachment is obsolete: true
Keywords: checkin-needed
Keywords: checkin-needed
Attachment #9039984 - Attachment description: Bug 1497827 Do not display EV labels instead of domains in site identity header → Bug 1497827 - Do not display EV labels instead of domains in site identity header

Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/65be95938473
Do not display EV labels instead of domains in site identity header r=johannh

Keywords: checkin-needed

https://hg.mozilla.org/mozilla-central/rev/65be95938473

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: