1497838 - Consider removing Geolocation values in SECURITY_UI

Status: RESOLVED FIXED

(Firefox :: Security, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

https://searchfox.org/mozilla-central/rev/80ac71c1c54af788b32e851192dfd2de2ec18e18/security/manager/ssl/nsISecurityUITelemetry.idl#92-95

This is duplicated with https://mzl.la/2zBbHpW (only that that one is even more detailed) and I doubt anyone has seriously used this data in the recent years. It's so unrelated to other SECURITY_UI data that it should have its own probe (which it literally has).

Considering that this probe never expires we should be mindful of what we're collecting. If needed we can make the probe from https://mzl.la/2zBbHpW stop expire, since it's much more informative.

Comment 1

[Manish [:manishkk]]

Need to remove these lines only?

https://searchfox.org/mozilla-central/rev/80ac71c1c54af788b32e851192dfd2de2ec18e18/security/manager/ssl/nsISecurityUITelemetry.idl#92-95

Comment 2

[Johann Hofmann [:johannh]]

(In reply to Manish [:manishkk] from comment #1)

Need to remove these lines only?

https://searchfox.org/mozilla-central/rev/80ac71c1c54af788b32e851192dfd2de2ec18e18/security/manager/ssl/nsISecurityUITelemetry.idl#92-95

No, the are places where this is used that need to be removed as well: https://searchfox.org/mozilla-central/search?q=WARNING_GEOLOCATION_REQUEST&case=false&regexp=false&path=

Comment 4

[Manish [:manishkk]]

Attachment: Bug 1497838- Consider removing Geolocation values in SECURITY_UI

Comment 5

[Manish [:manishkk]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=38b7fe1af6b90486708a64ec1ee46a973c400d4d

Comment 6

[Manish [:manishkk]]

Attachment: Bug 1497838- Consider removing Geolocation values in SECURITY_UI

Comment 7

[Manish [:manishkk]]

Attachment: Bug 1497838- Consider removing Geolocation values in SECURITY_UI

Comment 8

[Manish [:manishkk]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=689085a5da15c51e1898423421e874367e9030a0

Comment 9

[Manish [:manishkk]]

Attachment: Bug 1497838- Consider removing Geolocation values in SECURITY_UI

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/789cf4d290de
Consider removing Geolocation values in SECURITY_UI r=johannh

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/789cf4d290de