1497871 - Mozversion - display version information only when logging level is DEBUG

Status: RESOLVED WORKSFORME

(Testing :: Mozbase, enhancement, P3)

Description

[Silviu Florin]

We are using mozversion in Iris to retrieve Firefox version information
Every time we are calling get_version(), all version information is displayed in the console. Can this behavior be changed? For example to display version information only when the logging level is DEBUG?

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Instead of changing the logging level to debug, I would suggest that it's only useful to log this information when mozversion is being used as a command-line tool. Perhaps a compromise would be to set the level to debug when mozversion is not being invoked from the command line.

Comment 2

[Geoff Brown [:gbrown]]

I am reluctant to change the existing logging behavior: It seems reasonable and other callers may be relying on it.


There are work-arounds:

If running as a command-line tool, the output can be redirected: 

   python mozversion.py > /dev/null

If running as a command-line tool, output can be redirected via logging parameters: 

   python mozversion.py --log-mach=myfile

Otherwise, if calling get_version(), the "mozversion" logger can be manipulated:

     mozlog.commandline.setup_logging('mozversion', None, {})
     get_version(...)


Good enough?

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I'd be surprised if anything is relying on the logging of version details rather than the response from the call to `get_version`. I'd be more concerned about silencing the logging entirely and potentially missing warning and more critical level logging.

Comment 4

[Silviu Florin]

Thanks Geoff for your reply. Your solution to manipulate the "mozversion" logger is exactly what I need.