149791 - make superseded items invisible in selection list

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[dprice (gone)]

Add a new flag to the supersede attribute called ShowIfSuperseded  If this value
is set to TRUE, then we'll show the superseded component.  The default behavior
will be to hide a superseded component.

Comment 1

[Gregg Landskov (gone)]

Is this pertaining to the Real Player choice?

Comment 2

[Daniel Veditz [:dveditz]]

Can anyone think of a reason for showing the item? I don't want to include lots
of options that no one's going to use -- or worse, items that are broken but we
have to support into the future -- all it is is code bloat, more to test, more
that can go wrong.

Let's invent ShowIfSuperseded when someone makes a case for wanting it; for now
just hardcode in the behavior we want. If you ask me, if you're going to show
anything it makes a whole lot more sense to be deselected but *enabled*, maybe
with a confirm or alert if the item it turned on (and there'd have to be a slot
for the confirm text, right?). That way if we mistakenly supersede something it
gives the user a fighting chance to say "Yeah, this is usually not what people
want, BUT THIS TIME I'M RIGHT". But we're not going to implement all that, so
don't complicate things by carrying along behavior that didn't really work for
folks in the beta.

I'll plus this, though, because we need a place to hang the patch

[was: add ShowIfSuperseded option of SUPERSEDE attribute in config.ini (win32
installer)]

Comment 3

[dprice (gone)]

Attachment: patch 1

Dan's idea sure makes for a smaller patch. ;)

Comment 4

[Curt Patrick (gone)]

Comment on attachment 86783 [details] [diff] [review]
patch 1

r=curt

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 86783 [details] [diff] [review]
patch 1

sr=dveditz

Comment 6

[dprice (gone)]

on the trunk

Comment 7

[dprice (gone)]

I'm not sure why this doesn't have ADT RTM numbers on it.  I'm marking adt1.0.1
because it needs to be in the branch.

Comment 8

[scottputterman]

Let's get this verified on the trunk first.

Comment 9

[K'Trina Medina]

Is there a specific way to verify this fix on the trunk besides code fix? 

Comment 10

[Daniel Veditz [:dveditz]]

Real should be set to supersede on the trunk as well as branch so verify the
same way. W/out real installed it should show up in the custom and recommended
additional lists, w/real installed it should not be there but you should see the
later message about configuring a found real.

Comment 11

[Jaime Rodriguez, Jr.]

ktrina - how we doing on the verification for this fix?

Comment 12

[K'Trina Medina]

Verified that RealPlayer is not included on additional components menu on custom
install (build 2002-06-21-09-trunk)when Real Player is already installed. On
branch (build 06-21-08-1.0) RealPlayer on the menu but it was greyed out. 

Comment 13

[dprice (gone)]

That is as it should be. this isn't on the branch yet.  Thanks K'Trina

Comment 14

[K'Trina Medina]

No problem. I'll mark it verified when it's on the branch. 

Comment 15

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on ADT's behalf) approval for checkin to the 1.0 branch, pending
drivers' approval. pls check this in asap, then add the "fixed1.0.1" keyword.

Comment 16

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 17

[dprice (gone)]

on the branch

Comment 18

[Grace Bush]

trunk 2002070204, branch 2002070208