Open
Bug 1497911
Opened 6 years ago
Updated 2 years ago
Stop sending "type" property out of attach/detach requests on target actors
Categories
(DevTools :: Framework, enhancement, P3)
DevTools
Framework
Tracking
(Not tracked)
NEW
People
(Reporter: ochameau, Unassigned)
References
Details
The targets actors are replying to attach/detach request a response with a `type` property. This is confusing as that's a special property name used in low level transport layer. It is typically the request/event name. In addition to that, these property are never read in production code. This is only asserted in tests. Also, attach returns `type: "tabDetached"` which is confusing after all the renamings we did to replace "tab" by "target" or "browsing-context".
Reporter | ||
Comment 1•6 years ago
|
||
attach/type: "tabAttached" are being send from these places: https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/addon.js#163 https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#915 detach/type: "detached are being sent from these places: https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/addon.js#176 https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#928 https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/worker.js#89
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•