"Tracking Protection" string still appears in "Show site information Panel"

VERIFIED FIXED in Firefox 66

Status

()

defect
P3
minor
VERIFIED FIXED
8 months ago
4 months ago

People

(Reporter: ccomorasu, Assigned: jallmann)

Tracking

63 Branch
Firefox 66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 unaffected, firefox63 wontfix, firefox64 wontfix, firefox65 wontfix, firefox66 verified)

Details

(Whiteboard: [privacy65])

Attachments

(2 attachments)

Posted image issue.png
[Affected versions]:
 Fx 63.0b13
 Fx 64.0a1

[Affected platforms]:
 Windows 10 x64
 macOS 10.13.6
 Ubuntu 16.04 LTS

[Steps to reproduce]:
 1. Launch Firefox.
 2. Go to any website and open the "Show site information" panel.
 3. Hover over the gear wheel button.

[Expected result]:
 The following string is displayed: "Open Content Blocking Preferences".

[Actual result]:
 The following string is displayed: "Open Tracking Protection Preferences".

[Regression range]:
 This is not a regression as it was supposed to be an UI enhancement.

[Additional notes]:
 a. Please note the attachment.
 b. For beta builds the "browser.contentblocking.ui.enabled" pref code must have the value "true".
Has Regression Range: --- → no
Has STR: --- → yes
Whiteboard: [privacy-panel]
Priority: -- → P3
Blocks: 1481233
No longer blocks: privacy-ui
Whiteboard: [privacy-panel] → [privacy65]

So it seems like during content blocking development we completely removed that tooltip. It would be great to have "Open Content Blocking Preferences" displayed there again. Jonas was looking for a good first bug!

Assignee: nobody → jallmann
Status: NEW → ASSIGNED
Assignee

Comment 2

4 months ago
Re-inserted correct tooltip for Content Blocking settings button.
Assignee

Updated

4 months ago
Keywords: checkin-needed

Comment 3

4 months ago

Pushed by opoprus@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/530ea0f2b9ab
Fix Content Blocking tooltip, r=johannh

Keywords: checkin-needed

Comment 4

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

I reproduced this issue using Fx 65.0b11, on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 66.0a1 (2018-01-17) on macOS 10.13.6, Windows 10 x64 and Ubuntu 16.04 LTS.

Flags: needinfo?(jallmann)

Sorry for the spam.

Status: RESOLVED → VERIFIED
Flags: needinfo?(jallmann)
You need to log in before you can comment on or make changes to this bug.