1497922 - "Tracking Protection" string still appears in "Show site information Panel"

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P3)

Description

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Attachment: issue.png

[Affected versions]:
 Fx 63.0b13
 Fx 64.0a1

[Affected platforms]:
 Windows 10 x64
 macOS 10.13.6
 Ubuntu 16.04 LTS

[Steps to reproduce]:
 1. Launch Firefox.
 2. Go to any website and open the "Show site information" panel.
 3. Hover over the gear wheel button.

[Expected result]:
 The following string is displayed: "Open Content Blocking Preferences".

[Actual result]:
 The following string is displayed: "Open Tracking Protection Preferences".

[Regression range]:
 This is not a regression as it was supposed to be an UI enhancement.

[Additional notes]:
 a. Please note the attachment.
 b. For beta builds the "browser.contentblocking.ui.enabled" pref code must have the value "true".

Comment 1

[Johann Hofmann [:johannh]]

So it seems like during content blocking development we completely removed that tooltip. It would be great to have "Open Content Blocking Preferences" displayed there again. Jonas was looking for a good first bug!

Comment 2

[Jonas Allmann [:jallmann]]

Attachment: Bug 1497922 - Fix Content Blocking tooltip, r=johannh

Re-inserted correct tooltip for Content Blocking settings button.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/530ea0f2b9ab
Fix Content Blocking tooltip, r=johannh

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/530ea0f2b9ab

Comment 5

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using Fx 65.0b11, on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 66.0a1 (2018-01-17) on macOS 10.13.6, Windows 10 x64 and Ubuntu 16.04 LTS.

Comment 6

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Sorry for the spam.