Closed
Bug 1497929
Opened 6 years ago
Closed 6 years ago
Wait for actual promise in TelemetryController idle test
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: janerik, Assigned: janerik)
Details
Attachments
(1 file)
[1] waits for the deferred object, not for the actual promise. Awaiting a value always resolves immediately, making the test pass no matter what. [1]: https://searchfox.org/mozilla-central/rev/65f9687eb192f8317b4e02b0b791932eff6237cc/toolkit/components/telemetry/tests/unit/test_TelemetryController_idle.js#52
|
Assignee | |
Updated•6 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 1•6 years ago
|
||
Previously, the test never waited for the notification to actually fire.
Pushed by jrediger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8de1df187949 Await the underlying promise r=chutten
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8de1df187949
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•