Wait for actual promise in TelemetryController idle test

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P1
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: janerik, Assigned: janerik)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

7 months ago
[1] waits for the deferred object, not for the actual promise.
Awaiting a value always resolves immediately, making the test pass no matter what.

[1]: https://searchfox.org/mozilla-central/rev/65f9687eb192f8317b4e02b0b791932eff6237cc/toolkit/components/telemetry/tests/unit/test_TelemetryController_idle.js#52
Assignee

Updated

7 months ago
Priority: -- → P1
Assignee

Comment 1

7 months ago
Previously, the test never waited for the notification to actually fire.

Comment 2

7 months ago
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8de1df187949
Await the underlying promise r=chutten

Comment 3

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8de1df187949
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.