Closed
Bug 1497931
Opened 6 years ago
Closed 5 years ago
Switch from bootstrap to reactstrap
Categories
(Tree Management :: Treeherder: Frontend, enhancement, P1)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: sclements)
References
Details
Attachments
(2 files)
Since:
* we're currently using a mixture of the two, and they only share CSS, so the bundle includes twice the JS it needs to
* bootstrap requires jquery (unlike reactstrap), which further bloats our bundle - and once we move away from angular (which uses jquery) plus remove our own usages (bug 1492003), bootstrap will be the only non-perfherder thing left using it
* reactstrap is much more readable to contributors than plain bootstrap IMO
|
Reporter | |
Updated•6 years ago
|
No longer blocks: treeherder-react
|
Assignee | |
Comment 1•5 years ago
•
|
||
There's still Bootstrap/jquery being used in the HelpMenu and Login components (and potentially others), so we can't remove it until those have been switched over to reactstrap.
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → sclements
Status: NEW → ASSIGNED
Priority: P3 → P1
|
||
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Merged first part (convert login and help menu components): https://github.com/mozilla/treeherder/commit/2e7531044c8a7384d2def118d8c89593a5a4e508
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•