Permafail tier2 LeakSanitizer | leak at mozilla::net::nsStandardURL::TemplatedMutator, Init, mozilla::net::nsStandardURL::TemplatedMutator, operator

RESOLVED FIXED in Firefox 64

Status

()

defect
P5
normal
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: intermittent-bug-filer, Assigned: valentin)

Tracking

(Blocks 2 bugs, {intermittent-failure, memory-leak})

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox63 unaffected, firefox64 fixed, firefox65 fixed)

Details

(Whiteboard: [stockwell disable-recommended])

Attachments

(3 attachments)

Reporter

Description

7 months ago
treeherder
Filed by: dvarga [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=204531311&repo=autoland

https://queue.taskcluster.net/v1/task/d_V7AR6-TDGdKJU2ULL_EA/runs/0/artifacts/public/logs/live_backing.log

[task 2018-10-10T15:56:47.166Z] 15:56:47     INFO - Browser exited with return code 0
[task 2018-10-10T15:56:47.167Z] 15:56:47     INFO - INFO | LeakSanitizer | SUMMARY: AddressSanitizer: 3784 byte(s) leaked in 26 allocation(s).
[task 2018-10-10T15:56:47.168Z] 15:56:47     INFO - LeakSanitizer | To show the addresses of leaked objects add report_objects=1 to LSAN_OPTIONS
[task 2018-10-10T15:56:47.168Z] 15:56:47     INFO - This can be done in testing/mozbase/mozrunner/mozrunner/utils.py
[task 2018-10-10T15:56:47.170Z] 15:56:47     INFO - TEST-FAIL | LeakSanitizer | leak at Alloc, nsTSubstring, nsTSubstring, nsTSubstring
[task 2018-10-10T15:56:47.170Z] 15:56:47     INFO - INFO | LeakSanitizer | Frame Alloc matched a expected leak
[task 2018-10-10T15:56:47.170Z] 15:56:47     INFO - TEST-FAIL | LeakSanitizer | leak at MakeUnique, mozilla::ChromiumCDMProxy::Init, InvokeMethod, InvokeCallbackMethod
[task 2018-10-10T15:56:47.170Z] 15:56:47     INFO - INFO | LeakSanitizer | Frame MakeUnique matched a expected leak
[task 2018-10-10T15:56:47.170Z] 15:56:47     INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::EMEDecryptor::EMEDecryptor, mozilla::EMEDecoderModule::CreateVideoDecoder, mozilla::H264Converter::CreateDecoder, mozilla::H264Converter::H264Converter
[task 2018-10-10T15:56:47.170Z] 15:56:47     INFO - INFO | LeakSanitizer | Frame mozilla::EMEDecryptor::EMEDecryptor matched a expected leak
[task 2018-10-10T15:56:47.171Z] 15:56:47     INFO - TEST-FAIL | LeakSanitizer | leak at Realloc, nsTArray_base, AppendElement, mozilla::CDMCaps::NotifyWhenKeyIdUsable
[task 2018-10-10T15:56:47.171Z] 15:56:47     INFO - INFO | LeakSanitizer | Frame Realloc matched a expected leak
[task 2018-10-10T15:56:47.171Z] 15:56:47     INFO - TEST-FAIL | LeakSanitizer | leak at Malloc, nsTArray_base, AppendElement, mozilla::CDMCaps::NotifyWhenKeyIdUsable
[task 2018-10-10T15:56:47.172Z] 15:56:47     INFO - INFO | LeakSanitizer | Frame Malloc matched a expected leak
[task 2018-10-10T15:56:47.172Z] 15:56:47     INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::dom::MediaKeys::CreateCDMProxy, mozilla::dom::MediaKeys::Init, mozilla::dom::MediaKeySystemAccess::CreateMediaKeys, createMediaKeys
[task 2018-10-10T15:56:47.173Z] 15:56:47     INFO - INFO | LeakSanitizer | Frame mozilla::dom::MediaKeys::CreateCDMProxy matched a expected leak
[task 2018-10-10T15:56:47.173Z] 15:56:47     INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::SchedulerGroup::CreateEventTargetFor, mozilla::SchedulerGroup::CreateEventTargets, mozilla::dom::TabGroup::TabGroup, mozilla::dom::nsIContentChild::GetConstructedEventTarget
[task 2018-10-10T15:56:47.174Z] 15:56:47     INFO - INFO | LeakSanitizer | Frame mozilla::SchedulerGroup::CreateEventTargetFor matched a expected leak
[task 2018-10-10T15:56:47.174Z] 15:56:47     INFO - TEST-FAIL | LeakSanitizer | leak at NewPage, Push, mozilla::EventQueue::PutEvent, mozilla::ThreadEventQueue
[task 2018-10-10T15:56:47.175Z] 15:56:47     INFO - INFO | LeakSanitizer | Frame NewPage matched a expected leak
[task 2018-10-10T15:56:47.175Z] 15:56:47     INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::EMEDecryptor::EMEDecryptor, mozilla::EMEDecoderModule::CreateAudioDecoder, mozilla::PDMFactory::CreateDecoderWithPDM, mozilla::MediaFormatReader::DecoderFactory::DoCreateDecoder
[task 2018-10-10T15:56:47.176Z] 15:56:47     INFO - INFO | LeakSanitizer | Frame mozilla::EMEDecryptor::EMEDecryptor matched a expected leak
[task 2018-10-10T15:56:47.177Z] 15:56:47     INFO - TEST-FAIL | LeakSanitizer | leak at Malloc, nsTArray_base, AppendElements, AppendElements
[task 2018-10-10T15:56:47.177Z] 15:56:47     INFO - INFO | LeakSanitizer | Frame Malloc matched a expected leak
[task 2018-10-10T15:56:47.178Z] 15:56:47  WARNING - u'runner_teardown': ()
[task 2018-10-10T15:56:47.178Z] 15:56:47     INFO - Closing logging queue
[task 2018-10-10T15:56:47.179Z] 15:56:47     INFO - queue closed
Assignee

Updated

7 months ago
Assignee: nobody → valentin.gosu
Bug 1467914 removed Init from the allowed leak list (Init was a method in the DNS code). It seems that suppressed this leak as well.
Comment hidden (Intermittent Failures Robot)
For posterity, the stack trace is for the leak is:
Indirect leak of 256 byte(s) in 2 object(s) allocated from:
    #0 0x559c79e64263 in malloc /builds/worker/workspace/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:88:3
    #1 0x7fd5c610ba72 in Alloc /builds/worker/workspace/build/src/xpcom/string/nsSubstring.cpp:260:22
    #2 0x7fd5c610ba72 in nsTSubstring<char>::StartBulkWriteImpl(unsigned int, unsigned int, bool, unsigned int, unsigned int, unsigned int) /builds/worker/workspace/build/src/xpcom/string/nsTSubstring.cpp:216
    #3 0x7fd5c6113e3d in nsTSubstring<char>::SetLength(unsigned int, std::nothrow_t const&) /builds/worker/workspace/build/src/xpcom/string/nsTSubstring.cpp:1046:5
    #4 0x7fd5c65abd14 in mozilla::net::nsStandardURL::BuildNormalizedSpec(char const*, mozilla::Encoding const*) /builds/worker/workspace/build/src/netwerk/base/nsStandardURL.cpp:782:16
    #5 0x7fd5c65b4ad5 in mozilla::net::nsStandardURL::SetSpecWithEncoding(nsTSubstring<char> const&, mozilla::Encoding const*) /builds/worker/workspace/build/src/netwerk/base/nsStandardURL.cpp:1534:14
    #6 0x7fd5c65cb795 in mozilla::net::nsStandardURL::Init(unsigned int, int, nsTSubstring<char> const&, char const*, nsIURI*) /builds/worker/workspace/build/src/netwerk/base/nsStandardURL.cpp:3219:16
    #7 0x7fd5c65dec9f in Init /builds/worker/workspace/build/src/netwerk/base/nsStandardURL.h:387:32
    #8 0x7fd5c65dec9f in non-virtual thunk to mozilla::net::nsStandardURL::TemplatedMutator<mozilla::net::nsStandardURL>::Init(unsigned int, int, nsTSubstring<char> const&, char const*, nsIURI*, nsIURIMutator**) /builds/worker/workspace/build/src/netwerk/base/nsStandardURL.h
    #9 0x7fd5c635530b in operator() /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIURIMutator.h:449:10
    #10 0x7fd5c635530b in std::_Function_handler<nsresult (nsIURIMutator*), std::function<nsresult (nsIURIMutator*)> const NS_MutatorMethod<nsresult (nsIStandardURLMutator::*)(unsigned int, int, nsTSubstring<char> const&, char const*, nsIURI*, nsIURIMutator**), nsIStandardURL::{unnamed type#1}, int, nsTString<char>, char const*, nsCOMPtr<nsIURI>, decltype(nullptr)>(nsresult (nsIStandardURLMutator::*)(unsigned int, int, nsTSubstring<char> const&, char const*, nsIURI*, nsIURIMutator**), nsIStandardURL::{unnamed type#1}, int, nsTString<char>, char const*, nsCOMPtr<nsIURI>, decltype(nullptr))::{lambda(nsIURIMutator*)#1}>::_M_invoke(std::_Any_data const&, nsIURIMutator*) /builds/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.9.4/../../../../include/c++/4.9.4/functional:2024
    #11 0x7fd5c6d4ad49 in operator() /builds/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.9.4/../../../../include/c++/4.9.4/functional:2440:14
    #12 0x7fd5c6d4ad49 in Apply /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIURIMutator.h:604
    #13 0x7fd5c6d4ad49 in mozilla::net::NewURI(nsTSubstring<char> const&, char const*, nsIURI*, int, nsIURI**) /builds/worker/workspace/build/src/netwerk/protocol/http/nsHttpHandler.cpp:141
    #14 0x7fd5c64fa4cf in mozilla::net::nsIOService::NewURI(nsTSubstring<char> const&, char const*, nsIURI*, nsIURI**) /builds/worker/workspace/build/src/netwerk/base/nsIOService.cpp:702:21
    #15 0x7fd5c6539e53 in NS_NewURI /builds/worker/workspace/build/src/netwerk/base/nsNetUtil.cpp:1948:25
    #16 0x7fd5c6539e53 in NS_NewURI(nsIURI**, char const*, nsIURI*, nsIIOService*) /builds/worker/workspace/build/src/netwerk/base/nsNetUtil.cpp:1990
    #17 0x7fd5d1df29c2 in nsWindowWatcher::URIfromURL(char const*, mozIDOMWindowProxy*, nsIURI**) /builds/worker/workspace/build/src/toolkit/components/windowwatcher/nsWindowWatcher.cpp:1634:10
    #18 0x7fd5d1de6707 in nsWindowWatcher::OpenWindowInternal(mozIDOMWindowProxy*, char const*, char const*, char const*, bool, bool, bool, nsIArray*, bool, bool, nsDocShellLoadInfo*, mozIDOMWindowProxy**) /builds/worker/workspace/build/src/toolkit/components/windowwatcher/nsWindowWatcher.cpp:675:10
    #19 0x7fd5d1ded4fc in OpenWindow2 /builds/worker/workspace/build/src/toolkit/components/windowwatcher/nsWindowWatcher.cpp:412:10
    #20 0x7fd5d1ded4fc in non-virtual thunk to nsWindowWatcher::OpenWindow2(mozIDOMWindowProxy*, char const*, char const*, char const*, bool, bool, bool, nsISupports*, bool, bool, nsDocShellLoadInfo*, mozIDOMWindowProxy**) /builds/worker/workspace/build/src/toolkit/components/windowwatcher/nsWindowWatcher.cpp
    #21 0x7fd5c9340bc0 in nsGlobalWindowOuter::OpenInternal(nsTSubstring<char16_t> const&, nsTSubstring<char16_t> const&, nsTSubstring<char16_t> const&, bool, bool, bool, bool, bool, nsIArray*, nsISupports*, nsDocShellLoadInfo*, bool, nsPIDOMWindowOuter**) /builds/worker/workspace/build/src/dom/base/nsGlobalWindowOuter.cpp:7024:21
    #22 0x7fd5c933f78e in OpenJS /builds/worker/workspace/build/src/dom/base/nsGlobalWindowOuter.cpp:5533:10
    #23 0x7fd5c933f78e in nsGlobalWindowOuter::OpenOuter(nsTSubstring<char16_t> const&, nsTSubstring<char16_t> const&, nsTSubstring<char16_t> const&, mozilla::ErrorResult&) /builds/worker/workspace/build/src/dom/base/nsGlobalWindowOuter.cpp:5508
    #24 0x7fd5cb0cb76c in mozilla::dom::Window_Binding::open(JSContext*, JS::Handle<JSObject*>, nsGlobalWindowInner*, JSJitMethodCallArgs const&) /builds/worker/workspace/build/src/obj-firefox/dom/bindings/WindowBinding.cpp:2382:56
    #25 0x7fd5cbd447dc in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::MaybeGlobalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) /builds/worker/workspace/build/src/dom/bindings/BindingUtils.cpp:3315:13
[...]

We should file a bug to maybe fix it.

Comment 6

7 months ago
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6e9980bbb079
Add mozilla::net::nsStandardURL::TemplatedMutator to LSAN suppression list in websockets WPT r=mccr8

Comment 7

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6e9980bbb079
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)

Comment 12

7 months ago
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0cf18ffee1c0
Add TemplatedMutator and nsStandardURL::Clone to expected lsan leaks in service-workers/service-worker r=mccr8
Assignee

Updated

7 months ago
Blocks: 1499202
Assignee

Updated

7 months ago
Blocks: 1499206

Comment 13

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0cf18ffee1c0
Status: REOPENED → RESOLVED
Last Resolved: 7 months ago7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
This continues to fail: https://treeherder.mozilla.org/logviewer.html#?job_id=205738600&repo=autoland&lineNumber=6402

"Init" and "operator" are missing from the leak whitelist.

Failure before the fix: https://treeherder.mozilla.org/logviewer.html#?job_id=204531311&repo=autoland&lineNumber=42506
Failure after the fix: https://treeherder.mozilla.org/logviewer.html#?job_id=205738600&repo=autoland&lineNumber=6402
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla64 → ---
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Assignee

Updated

7 months ago
Duplicate of this bug: 1499235

Comment 19

7 months ago
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/37f79d89dea2
Add nsStandardURL::TemplatedMutator to infrastructure/server WPT allowed list r=mccr8

Comment 20

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/37f79d89dea2
Status: REOPENED → RESOLVED
Last Resolved: 7 months ago7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Assignee

Updated

7 months ago
Duplicate of this bug: 1498563
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
You need to log in before you can comment on or make changes to this bug.