1497962 - Ensure that extra_prefs are passed as a list

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I was trying to set a preference via extra_prefs for some work in bug 1496627 (later figured out I didn't need that preference, so the patch in there doesn't include it) and was having a hard time figuring out why I was getting weird errors. 

Turns out, wptcommandline.py expects extra_prefs to be passed as a python list (eg ["pref=value"] or ["pref1=value","pref2=value2"]), so but it will happily attempt to use the string "pref=value" and then fail miserably.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Bug 1497962 - Ensure extra_prefs is passed as a list r?jgraham

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43470b75b0d4
Ensure extra_prefs is passed as a list r=jgraham

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13476 for changes under testing/web-platform/tests

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/43470b75b0d4

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13476
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/V6Te2TJjRGKcZh7qFxbB_w)

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged