Closed Bug 1497962 Opened 3 years ago Closed 3 years ago
Ensure that extra
_prefs are passed as a list
46 bytes, text/x-phabricator-request
|Details | Review|
I was trying to set a preference via extra_prefs for some work in bug 1496627 (later figured out I didn't need that preference, so the patch in there doesn't include it) and was having a hard time figuring out why I was getting weird errors. Turns out, wptcommandline.py expects extra_prefs to be passed as a python list (eg ["pref=value"] or ["pref1=value","pref2=value2"]), so but it will happily attempt to use the string "pref=value" and then fail miserably.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/43470b75b0d4 Ensure extra_prefs is passed as a list r=jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13476 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/web-platform-tests/wpt/pull/13476 * Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/V6Te2TJjRGKcZh7qFxbB_w)
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.