1497994 - Debug assert with SOCKS5 proxy and TFO

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[u408661]

While setting up to look into bug 1493724, I configured a local build (latest mozilla-central as of this morning, no other changes) pointed at the TOR SOCKS5 proxy (127.0.0.1:9150, DNS over SOCKS enabled), and at first page load, I hit the assertion at https://searchfox.org/mozilla-central/rev/80ac71c1c54af788b32e851192dfd2de2ec18e18/netwerk/protocol/http/nsHttpConnectionMgr.cpp#4474. Same thing happened when I restarted the browser after the crash. After disabling tfo, everything is fine.

It's not clear to me what the right course here is (should we disable TFO with SOCKS5? should we change the assertion?), nor how urgent of an issue this is, so ni? Dragana, as she's the TFO expert.

Comment 1

[Dragana Damjanovic [:dragana]]

The issue is not really urgent. I could fix this, probably by not trying tfo with socks. I think only if dns over socks is enabled we will hit this assertion.

Comment 2

[Dragana Damjanovic [:dragana]]

Attachment: Disable TFO for socks proxies.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f84155d8f25
Disable TFO for socks proxies. r=nwgh

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9f84155d8f25