1498056 - Using configuration profile to set Proxy policy does not respect SocksVersion

Status: RESOLVED INVALID

(Firefox :: Enterprise Policies, defect, P1)

Description

[Stefan [:StefanG_QA]]

STR:
1. Create a configuration profile using the below example:

<key>EnterprisePoliciesEnabled</key>
<true/>	
<key>Proxy</key>
<dict>
	<key>SocksVersion</key>
	<string>4</string>
	<key>Mode</key>
	<string>manual</string>
	<key>HTTPProxy</key>
	<string>proxy.softvision.com:8080</string>
	<key>Locked</key>
	<true/>
</dict>
2. Install the Configuration Profile
3. Navigate to about:preferences
4. Under Network settings click on 'Settings'
5. Verify the fields aren't editabled and are populated as follow:
  - Manual proxy configartion is selected
  - HTTP Proxy is set to: 'proxy.softvision.com' port:8080
  - SOCKS v4 is selected

AR: SocksVersion is not properly set. SOCKS v5 is selected
ER: SocksVersion should be respected. 'SOCKS v4' should be selected

Comment 1

[Stefan [:StefanG_QA]]

Attachment: org.mozilla.nightly.mobileconfig

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Oh, there's a bug in the configuration:

<string>4</string> should be <integer>4</integer>. Can you check if that works in that case?

Comment 3

[Stefan [:StefanG_QA]]

Attachment: org.mozilla.nightly.mobileconfig

I've tried changing the value type but I see the same result. Here is the  configuration profile with <integer>4</integer>.

Comment 4

[Stephen A Pohl [:spohl]]

Does this reproduce with JSON policies?

Comment 5

[Stefan [:StefanG_QA]]

Attachment: policies.json

This is not reproduced using the attached json file.

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Stephen, could you take a look to see if the parser is having problems reading <integer> items? Or if I advised comment 3 incorrectly?

If there's not a simple fix for this I'm thinking of working around it by supporting both integer or string parameters to SocksVersion

Comment 7

[:shell escalante]

Felipe, Is this a blocker for bug 1445943 (Enterprise Policies Support for MacOS) in Firefox 64?

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Yeah, I think so. If we don't manage to find a fix in time, we should at least do the workaround described in comment 6 so that the Proxy policy can be used.

Comment 9

[Stephen A Pohl [:spohl]]

This is due to a mistake in the configuration profile. SOCKSVersion was not capitalized properly (`SocksVersion` instead of `SOCKSVersion`). Note that it was spelled correctly in the policies.json, which is why this seemed to only affect configuration policies and not JSON policies.

If we want to make the parser more tolerant for capitalization, we should file a separate bug.

Comment 10

[Stephen A Pohl [:spohl]]

Attachment: org.mozilla.nightly.mobileconfig (works correctly)

Corrected configuration profile.