Closed Bug 1498070 Opened Last year Closed 11 months ago

Simplify and cache texture and framebuffer completeness

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

(Depends on 1 open bug)

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

No description provided.
We already cache framebuffer completeness, but we don't cache texture/sampling completeness for draw calls.
Trying various benchmarks with both profiling and raw scores doesn't show this being a win either way, really. If anything, slight perf regression.

I'm going to try caching at a slightly different level for ScopedResolveTexturesForDraw.

These patches do fix outstanding bugs though, so we want them in one form or another.
Attachment #9016127 - Attachment description: Bug 1498070 - Redo framebuffer and texture completeness validation and caching. - → Bug 1498070 - Simplify and cache framebuffer and texture completeness. -
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59befcc4a2d6
Simplify and cache framebuffer and texture completeness. - r=kvark
https://hg.mozilla.org/mozilla-central/rev/59befcc4a2d6
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Flags: qe-verify-
Depends on: 1503813
Blocks: 1506840
Depends on: 1510175
Depends on: 1515146
You need to log in before you can comment on or make changes to this bug.